Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 12728009: Introduce the DeviceStartUpFlags device policy. (Closed)

Created:
7 years, 9 months ago by pastarmovj
Modified:
7 years, 9 months ago
Reviewers:
Joao da Silva
CC:
chromium-reviews, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Introduce the DeviceStartUpFlags device policy. First step towards moving system-wide flags from local state to signed settings. BUG=chromium-os:39251 TEST=policy consistency tests pass. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188031

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -7 lines) Patch
M chrome/app/policy/policy_templates.json View 2 chunks +18 lines, -1 line 0 comments Download
M chrome/browser/chromeos/settings/cros_settings_names.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/settings/cros_settings_names.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/settings/device_settings_provider.cc View 4 chunks +33 lines, -6 lines 0 comments Download
M chrome/browser/policy/device_policy_decoder_chromeos.cc View 1 chunk +17 lines, -0 lines 0 comments Download
M chrome/browser/policy/proto/chrome_device_policy.proto View 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/test/data/policy/policy_test_cases.json View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
pastarmovj
Hey can you please stamp this CL. It is basically only the piece of the ...
7 years, 9 months ago (2013-03-13 17:24:02 UTC) #1
Joao da Silva
lgtm I thought the other CL was landed? (https://src.chromium.org/viewvc/chrome?view=rev&revision=186837) Was it reverted?
7 years, 9 months ago (2013-03-13 19:07:46 UTC) #2
pastarmovj
On 2013/03/13 19:07:46, Joao da Silva wrote: > lgtm > > I thought the other ...
7 years, 9 months ago (2013-03-13 20:20:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pastarmovj@chromium.org/12728009/1
7 years, 9 months ago (2013-03-13 20:25:16 UTC) #4
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 9 months ago (2013-03-13 22:27:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pastarmovj@chromium.org/12728009/1
7 years, 9 months ago (2013-03-13 23:55:37 UTC) #6
pastarmovj
7 years, 9 months ago (2013-03-14 09:13:43 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 manually as r188031 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698