Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 12728008: Revert 186837 "Move pref backing up flags from local state to de..." (Closed)

Created:
7 years, 9 months ago by pastarmovj
Modified:
7 years, 9 months ago
Reviewers:
pastarmovj
CC:
chromium-reviews, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Revert 186837 "Move pref backing up flags from local state to de..." NOTE: Will recommit once session manager can handle flags for us. Move pref backing up flags from local state to device settings on ChromeOS. BUG=chromium:18331 TEST=Existing unit and browser tests should pass. Review URL: https://chromiumcodereview.appspot.com/12452003 TBR=pastarmovj@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187883

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -170 lines) Patch
M chrome/app/policy/policy_templates.json View 2 chunks +1 line, -18 lines 0 comments Download
M chrome/browser/about_flags.cc View 3 chunks +2 lines, -65 lines 0 comments Download
M chrome/browser/chromeos/settings/cros_settings_names.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/settings/cros_settings_names.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/settings/device_settings_provider.cc View 8 chunks +6 lines, -54 lines 0 comments Download
M chrome/browser/policy/device_policy_decoder_chromeos.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M chrome/browser/policy/proto/chrome_device_policy.proto View 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/flags_ui.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/data/policy/policy_test_cases.json View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
pastarmovj
7 years, 9 months ago (2013-03-13 17:05:15 UTC) #1
pastarmovj
7 years, 9 months ago (2013-03-13 17:05:52 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r187883.

Powered by Google App Engine
This is Rietveld 408576698