Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Unified Diff: src/heap/heap.cc

Issue 1272763005: [stubs] Store typeof string on Oddballs. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/factory.cc ('k') | src/hydrogen-instructions.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/heap.cc
diff --git a/src/heap/heap.cc b/src/heap/heap.cc
index 0e027f83b026a98b73fa4402d8828fffebb84454..63232d955c8f57326cbf4df5854fe30cbbc48b0b 100644
--- a/src/heap/heap.cc
+++ b/src/heap/heap.cc
@@ -3183,44 +3183,47 @@ void Heap::CreateInitialObjects() {
// Finish initializing oddballs after creating the string table.
Oddball::Initialize(isolate(), factory->undefined_value(), "undefined",
- factory->nan_value(), Oddball::kUndefined);
+ factory->nan_value(), "undefined", Oddball::kUndefined);
// Initialize the null_value.
Oddball::Initialize(isolate(), factory->null_value(), "null",
- handle(Smi::FromInt(0), isolate()), Oddball::kNull);
+ handle(Smi::FromInt(0), isolate()), "object",
+ Oddball::kNull);
set_true_value(*factory->NewOddball(factory->boolean_map(), "true",
handle(Smi::FromInt(1), isolate()),
- Oddball::kTrue));
+ "boolean", Oddball::kTrue));
set_false_value(*factory->NewOddball(factory->boolean_map(), "false",
handle(Smi::FromInt(0), isolate()),
- Oddball::kFalse));
+ "boolean", Oddball::kFalse));
set_the_hole_value(*factory->NewOddball(factory->the_hole_map(), "hole",
handle(Smi::FromInt(-1), isolate()),
- Oddball::kTheHole));
+ "undefined", Oddball::kTheHole));
- set_uninitialized_value(*factory->NewOddball(
- factory->uninitialized_map(), "uninitialized",
- handle(Smi::FromInt(-1), isolate()), Oddball::kUninitialized));
+ set_uninitialized_value(
+ *factory->NewOddball(factory->uninitialized_map(), "uninitialized",
+ handle(Smi::FromInt(-1), isolate()), "undefined",
+ Oddball::kUninitialized));
- set_arguments_marker(*factory->NewOddball(
- factory->arguments_marker_map(), "arguments_marker",
- handle(Smi::FromInt(-4), isolate()), Oddball::kArgumentMarker));
+ set_arguments_marker(
+ *factory->NewOddball(factory->arguments_marker_map(), "arguments_marker",
+ handle(Smi::FromInt(-4), isolate()), "undefined",
+ Oddball::kArgumentMarker));
set_no_interceptor_result_sentinel(*factory->NewOddball(
factory->no_interceptor_result_sentinel_map(),
"no_interceptor_result_sentinel", handle(Smi::FromInt(-2), isolate()),
- Oddball::kOther));
+ "undefined", Oddball::kOther));
set_termination_exception(*factory->NewOddball(
factory->termination_exception_map(), "termination_exception",
- handle(Smi::FromInt(-3), isolate()), Oddball::kOther));
+ handle(Smi::FromInt(-3), isolate()), "undefined", Oddball::kOther));
set_exception(*factory->NewOddball(factory->exception_map(), "exception",
handle(Smi::FromInt(-5), isolate()),
- Oddball::kException));
+ "undefined", Oddball::kException));
for (unsigned i = 0; i < arraysize(constant_string_table); i++) {
Handle<String> str =
« no previous file with comments | « src/factory.cc ('k') | src/hydrogen-instructions.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698