Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 1272763005: [stubs] Store typeof string on Oddballs. (Closed)

Created:
5 years, 4 months ago by Benedikt Meurer
Modified:
5 years, 4 months ago
Reviewers:
Yang
CC:
v8-dev, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] Store typeof string on Oddballs. First step to simplify the TypeofStub. This is similar to the optimization that we use for ToNumber and ToString on Oddballs already. R=yangguo@chromium.org Committed: https://crrev.com/a0364972fcf5383078017914cc2fe75a02889117 Cr-Commit-Position: refs/heads/master@{#30108}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -57 lines) Patch
M include/v8.h View 1 chunk +1 line, -1 line 0 comments Download
M src/code-stubs-hydrogen.cc View 4 chunks +3 lines, -21 lines 0 comments Download
M src/factory.h View 1 chunk +2 lines, -3 lines 0 comments Download
M src/factory.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M src/heap/heap.cc View 1 chunk +17 lines, -14 lines 0 comments Download
M src/hydrogen-instructions.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/objects.h View 3 chunks +9 lines, -8 lines 0 comments Download
M src/objects.cc View 1 chunk +7 lines, -6 lines 0 comments Download
M src/objects-inl.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 4 months ago (2015-08-11 10:14:14 UTC) #1
Benedikt Meurer
Hey Yang, As discussed offline: I'm going to simplify the TypeofStub. This is the obvious ...
5 years, 4 months ago (2015-08-11 10:14:58 UTC) #2
Yang
On 2015/08/11 10:14:14, Benedikt Meurer wrote: lgtm.
5 years, 4 months ago (2015-08-11 10:19:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1272763005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1272763005/1
5 years, 4 months ago (2015-08-11 10:43:57 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-11 10:47:29 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-11 10:47:51 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a0364972fcf5383078017914cc2fe75a02889117
Cr-Commit-Position: refs/heads/master@{#30108}

Powered by Google App Engine
This is Rietveld 408576698