chrome/app/theme/README - Issue 1272763003: optimize-ico-files: Automatically convert large BMPs to PNG format.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/app/theme/README

Issue 1272763003: optimize-ico-files: Automatically convert large BMPs to PNG format. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@optimize-ico-files

Patch Set: Added TODO to compress all the images (no longer need XP). Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | tools/resources/ico_tools.py » ('j') | no next file with comments »

OLD	NEW
1 PNG Images	1 PNG Images

2 ==========	2 ==========

3	3

4 Please run src/tools/resources/optimize-png-files.sh on all new icons. For examp le:	4 Please run src/tools/resources/optimize-png-files.sh on all new icons. For examp le:

5 tools/resources/optimize-png-files.sh -o2 new_pngs_dir	5 tools/resources/optimize-png-files.sh -o2 new_pngs_dir

6	6

7 If this script does not work for some reason, at least pngcrush the files:	7 If this script does not work for some reason, at least pngcrush the files:

8 mkdir crushed	8 mkdir crushed

9 pngcrush -d crushed -brute -reduce -rem alla new/*.png	9 pngcrush -d crushed -brute -reduce -rem alla new/*.png

10	10

(...skipping 23 matching lines...) Expand all Loading...
34 2. Combine the images into an ICO file. With ImageMagick:	34 2. Combine the images into an ICO file. With ImageMagick:

35	35

36 convert FILENAME-256.png FILENAME-{48,32,16}{-indexed,}.png FILENAME.ico	36 convert FILENAME-256.png FILENAME-{48,32,16}{-indexed,}.png FILENAME.ico

37	37

38 3. Unfortunately, the 8-bit images have been converted back into 32-bit images.	38 3. Unfortunately, the 8-bit images have been converted back into 32-bit images.

39 Open the icon in GIMP and re-export it. This will also convert the large	39 Open the icon in GIMP and re-export it. This will also convert the large

40 256 image into a compressed PNG.	40 256 image into a compressed PNG.

41 4. Run src/tools/resources/optimize-ico-files.py on the resulting .ico file.	41 4. Run src/tools/resources/optimize-ico-files.py on the resulting .ico file.

42	42

43 You can also run src/tools/resources/optimize-ico-files.py on existing .ico	43 You can also run src/tools/resources/optimize-ico-files.py on existing .ico

44 files. This will run a basic PNG optimization pass and fix up any broken image	44 files. This will convert BMPs to PNGs and run a basic PNG optimization pass, as

45 masks (http://crbug.com/534679).	45 well as fix up any broken image masks (http://crbug.com/534679).

OLD	NEW