Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(992)

Issue 1272733002: [futex] Avoid accumulation errors in futex wait timeout (Closed)

Created:
5 years, 4 months ago by binji
Modified:
5 years, 4 months ago
Reviewers:
Michael Achenbach
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[futex] Avoid accumulation errors in futex wait timeout The code previously used a relative timeout and accumulated wait times to see if the timeout was exceeded. Now we convert the timeout into an absolute time, and always compare the current time against that. BUG=v8:4357 R=machenbach@chromium.org LOG=n Committed: https://crrev.com/ad1690d686575baadf8aa0fa820b0438e1a4b9a4 Cr-Commit-Position: refs/heads/master@{#30036}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -16 lines) Patch
M src/futex-emulation.cc View 2 chunks +14 lines, -16 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Achenbach
lgtm - thanks for fixing!
5 years, 4 months ago (2015-08-05 19:54:37 UTC) #1
Michael Achenbach
FYI: I added the v8: prefix to the BUG= line. Otherwise it points into chromium ...
5 years, 4 months ago (2015-08-05 20:46:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1272733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1272733002/1
5 years, 4 months ago (2015-08-05 20:56:17 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-05 20:58:10 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-05 20:58:24 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ad1690d686575baadf8aa0fa820b0438e1a4b9a4
Cr-Commit-Position: refs/heads/master@{#30036}

Powered by Google App Engine
This is Rietveld 408576698