src/effects/SkBitmapSource.cpp - Issue 1272713005: flag to use const& instead of const* for src-rect

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkBitmapSource.cpp

Issue 1272713005: flag to use const& instead of const* for src-rect (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/effects/SkBitmapSource.cpp

diff --git a/src/effects/SkBitmapSource.cpp b/src/effects/SkBitmapSource.cpp

index 859e8aff62ac67ad4d1d3a78e817125aca4e50d0..ecaffcf7c9b2378517ec92d0a8bb38741b444a5d 100644

--- a/src/effects/SkBitmapSource.cpp

+++ b/src/effects/SkBitmapSource.cpp

@@ -84,7 +84,7 @@ bool SkBitmapSource::onFilterImage(Proxy* proxy, const SkBitmap&, const Context&

paint.setFilterQuality(

fSrcRect.width() == dstRect.width() && fSrcRect.height() == dstRect.height() ?

kNone_SkFilterQuality : fFilterQuality);

- canvas.drawBitmapRect(fBitmap, &fSrcRect, dstRect, &paint, SkCanvas::kStrict_SrcRectConstraint);

+ canvas.drawBitmapRect(fBitmap, fSrcRect, dstRect, &paint, SkCanvas::kStrict_SrcRectConstraint);

*result = device.get()->accessBitmap(false);

offset->fX = dstIRect.fLeft;