samplecode/SampleAtlas.cpp - Issue 1272713005: flag to use const& instead of const* for src-rect

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: samplecode/SampleAtlas.cpp

Issue 1272713005: flag to use const& instead of const* for src-rect (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: samplecode/SampleAtlas.cpp

diff --git a/samplecode/SampleAtlas.cpp b/samplecode/SampleAtlas.cpp

index 4cce4879c4d1b762424a1e4d47644ab6e5ce2f0c..e11bf7e2c16eedbb61b7d6d28cd9a1322e98808d 100644

--- a/samplecode/SampleAtlas.cpp

+++ b/samplecode/SampleAtlas.cpp

@@ -33,7 +33,7 @@ static void draw_atlas_sim(SkCanvas* canvas, SkImage* atlas, const SkRSXform xfo

canvas->save();

canvas->concat(matrix);

- canvas->drawImageRect(atlas, &tex[i], tex[i].makeOffset(-tex[i].x(), -tex[i].y()), paint,

+ canvas->drawImageRect(atlas, tex[i], tex[i].makeOffset(-tex[i].x(), -tex[i].y()), paint,

SkCanvas::kFast_SrcRectConstraint);

canvas->restore();

}