gm/drawbitmaprect.cpp - Issue 1272713005: flag to use const& instead of const* for src-rect - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(24)

My Issues | Starred Open | Closed | All

Unified Diff: gm/drawbitmaprect.cpp

Issue 1272713005: flag to use const& instead of const* for src-rect (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « gm/bleed.cpp ('k') | gm/image.cpp » ('j') | gm/image.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gm/drawbitmaprect.cpp

diff --git a/gm/drawbitmaprect.cpp b/gm/drawbitmaprect.cpp

index 9db5ca71dae4b303245ce8428cc631ad300b45d7..2a41465a3591000002c682f412cb9d8285cc3c1f 100644

--- a/gm/drawbitmaprect.cpp

+++ b/gm/drawbitmaprect.cpp

@@ -152,10 +152,7 @@ protected:

static const int kPadY = 40;

SkPaint paint;

paint.setAlpha(0x20);

- canvas->drawBitmapRect(fLargeBitmap, NULL,

- SkRect::MakeWH(gSize * SK_Scalar1,

- gSize * SK_Scalar1),

- &paint);

+ canvas->drawBitmapRect(fLargeBitmap, SkRect::MakeIWH(gSize, gSize), &paint);

canvas->translate(SK_Scalar1 * kPadX / 2,

SK_Scalar1 * kPadY / 2);

SkPaint blackPaint;

« no previous file with comments | « gm/bleed.cpp ('k') | gm/image.cpp » ('j') | gm/image.cpp » ('J')

Powered by Google App Engine

This is Rietveld 408576698