Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Side by Side Diff: src/effects/SkTestImageFilters.cpp

Issue 1272713005: flag to use const& instead of const* for src-rect (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright 2011 Google Inc. 2 * Copyright 2011 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #include "SkTestImageFilters.h" 8 #include "SkTestImageFilters.h"
9 #include "SkCanvas.h" 9 #include "SkCanvas.h"
10 #include "SkDevice.h" 10 #include "SkDevice.h"
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
62 } 62 }
63 63
64 // upscale 64 // upscale
65 { 65 {
66 SkBaseDevice* dev = proxy->createDevice(src.width(), src.height()); 66 SkBaseDevice* dev = proxy->createDevice(src.width(), src.height());
67 if (NULL == dev) { 67 if (NULL == dev) {
68 return false; 68 return false;
69 } 69 }
70 OwnDeviceCanvas canvas(dev); 70 OwnDeviceCanvas canvas(dev);
71 71
72 SkRect r = SkRect::MakeWH(SkIntToScalar(src.width()), 72 canvas.drawBitmapRect(tmp, SkRect::MakeIWH(src.width(), src.height()), n ullptr);
73 SkIntToScalar(src.height()));
74 canvas.drawBitmapRect(tmp, r);
75 *result = dev->accessBitmap(false); 73 *result = dev->accessBitmap(false);
76 } 74 }
77 return true; 75 return true;
78 } 76 }
79 77
80 SkFlattenable* SkDownSampleImageFilter::CreateProc(SkReadBuffer& buffer) { 78 SkFlattenable* SkDownSampleImageFilter::CreateProc(SkReadBuffer& buffer) {
81 SK_IMAGEFILTER_UNFLATTEN_COMMON(common, 1); 79 SK_IMAGEFILTER_UNFLATTEN_COMMON(common, 1);
82 return Create(buffer.readScalar(), common.getInput(0)); 80 return Create(buffer.readScalar(), common.getInput(0));
83 } 81 }
84 82
85 void SkDownSampleImageFilter::flatten(SkWriteBuffer& buffer) const { 83 void SkDownSampleImageFilter::flatten(SkWriteBuffer& buffer) const {
86 this->INHERITED::flatten(buffer); 84 this->INHERITED::flatten(buffer);
87 buffer.writeScalar(fScale); 85 buffer.writeScalar(fScale);
88 } 86 }
89 87
90 #ifndef SK_IGNORE_TO_STRING 88 #ifndef SK_IGNORE_TO_STRING
91 void SkDownSampleImageFilter::toString(SkString* str) const { 89 void SkDownSampleImageFilter::toString(SkString* str) const {
92 str->appendf("SkDownSampleImageFilter: ("); 90 str->appendf("SkDownSampleImageFilter: (");
93 str->append(")"); 91 str->append(")");
94 } 92 }
95 #endif 93 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698