flag to use const& instead of const* for src-rect

gm/image.cpp

 /*
  * Copyright 2011 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "gm.h"
 #include "SkData.h"
 #include "SkCanvas.h"
@@ skipping 74 matching lines @@
     src2.iset(-surf->width() / 2, -surf->height() / 2,
              surf->width(), surf->height());
     src3.iset(0, 0, surf->width() / 2, surf->height() / 2);
 
     SkRect dst1, dst2, dst3, dst4;
     dst1.set(0, 240, 65, 305);
     dst2.set(0, 320, 65, 385);
     dst3.set(0, 400, 65, 465);
     dst4.set(0, 480, 65, 545);
 
-    canvas->drawImageRect(imgR, &src1, dst1, usePaint ? &paint : NULL);
-    canvas->drawImageRect(imgG, &src2, dst2, usePaint ? &paint : NULL);
-    canvas->drawImageRect(imgR, &src3, dst3, usePaint ? &paint : NULL);
-    canvas->drawImageRect(imgG, NULL, dst4, usePaint ? &paint : NULL);
+    canvas->drawImageRect(imgR, src1, dst1, usePaint ? &paint : NULL);
+    canvas->drawImageRect(imgG, src2, dst2, usePaint ? &paint : NULL);
+    canvas->drawImageRect(imgR, src3, dst3, usePaint ? &paint : NULL);
+    canvas->drawImageRect(imgG, dst4, usePaint ? &paint : NULL);
 
     imgG->unref();
     imgR->unref();
 }
 
 class ImageGM : public skiagm::GM {
     void*   fBuffer;
     size_t  fBufferSize;
     SkSize  fSize;
     enum {
@@ skipping 120 matching lines @@
         }
         this->drawIntoImage(surface->getCanvas());
         return surface->newImageSnapshot();
     }
 
     void drawResized(SkCanvas* canvas, SkImage* image, int newW, int newH, const SkIRect* subset,
                      SkFilterQuality fq) {
         // canvas method
         SkPaint paint;
         paint.setFilterQuality(fq);
         SkRect dstR = SkRect::MakeWH(SkIntToScalar(newW), SkIntToScalar(newH));

[robertphillips, 2015/08/06 17:23:00]

SkRect srcR = SkRect::MakeWH(image->width(), image->height());

and do away with the 'legacy_' call?

         SkRect srcR;
         if (subset) {
             srcR.set(*subset);
         }
-        canvas->drawImageRect(image, subset ? &srcR : NULL, dstR, &paint);
+        canvas->legacy_drawImageRect(image, subset ? &srcR : NULL, dstR, &paint);
         canvas->translate(newW + 20.0f, 0);
 
         // image method
         SkAutoTUnref<SkImage> image2(image->newImage(newW, newH, subset, fq));
         canvas->drawImage(image2, 0, 0, NULL);
         canvas->translate(image2->width() + 20.0f, 0);
     }
 
     void drawImage(SkCanvas* canvas, SkImage* image, SkFilterQuality fq) {
 
@@ skipping 23 matching lines @@
             }
             canvas->translate(0, image->height() + 20.0f);
         }
     }
     
 private:
     typedef skiagm::GM INHERITED;
 };
 DEF_GM( return new ImageResizeGM; )