Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1272713002: [Sync] Move sync error controller to sync driver component (Closed)

Created:
5 years, 4 months ago by Nicolas Zea
Modified:
5 years, 4 months ago
Reviewers:
pavely
CC:
chromium-reviews, tim+watch_chromium.org, zea+watch_chromium.org, maxbogue+watch_chromium.org, pvalenzuela+watch_chromium.org, plaree+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Move sync error controller to sync driver component BUG=512483 Committed: https://crrev.com/9d2aded8572149441a844c1c56be4e2405c405f2 Cr-Commit-Position: refs/heads/master@{#342193}

Patch Set 1 #

Patch Set 2 : Fix GN #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -100 lines) Patch
M chrome/browser/sync/profile_sync_service.cc View 2 chunks +1 line, -1 line 0 comments Download
D chrome/browser/sync/sync_error_controller.h View 1 chunk +0 lines, -46 lines 0 comments Download
D chrome/browser/sync/sync_error_controller.cc View 1 chunk +0 lines, -36 lines 0 comments Download
M chrome/browser/sync/sync_error_notifier_ash.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/sync_error_notifier_ash_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/sync_global_error.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/sync_global_error_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M components/sync_driver.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M components/sync_driver/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
A + components/sync_driver/sync_error_controller.h View 3 chunks +8 lines, -7 lines 0 comments Download
A + components/sync_driver/sync_error_controller.cc View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Nicolas Zea
PTAL
5 years, 4 months ago (2015-08-05 18:43:29 UTC) #2
pavely
lgtm
5 years, 4 months ago (2015-08-05 20:32:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1272713002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1272713002/20001
5 years, 4 months ago (2015-08-06 17:24:38 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/89782)
5 years, 4 months ago (2015-08-06 19:34:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1272713002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1272713002/20001
5 years, 4 months ago (2015-08-06 19:38:38 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-06 20:56:38 UTC) #11
commit-bot: I haz the power
5 years, 4 months ago (2015-08-06 20:57:33 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/9d2aded8572149441a844c1c56be4e2405c405f2
Cr-Commit-Position: refs/heads/master@{#342193}

Powered by Google App Engine
This is Rietveld 408576698