Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 1272703003: Revert of [tracing] Throttle rate of heavy dumps and support to request light/heavy dumps (Closed)

Created:
5 years, 4 months ago by waffles
Modified:
5 years, 4 months ago
Reviewers:
nduca, pfeldman, ssid, petrcermak
CC:
chromium-reviews, wfh+watch_chromium.org, jam, yurys, darin-cc_chromium.org, devtools-reviews_chromium.org, tracing+reviews_chromium.org, erikwright+watch_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@light_dumps
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [tracing] Throttle rate of heavy dumps and support to request light/heavy dumps (patchset #5 id:80001 of https://codereview.chromium.org/1267963002/ ) Reason for revert: Suspect it breaks Linux telemetry tests (or possibly introduces flakiness): Example https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/28807 telemetry.internal.backends.chrome_inspector.tracing_backend_unittest.TracingBackendMemoryTest.testDumpMemorySuccess failed unexpectedly 0.2190s: Traceback (most recent call last): File "/mnt/data/b/build/slave/Linux_Tests/build/src/tools/telemetry/telemetry/internal/backends/chrome_inspector/tracing_backend_unittest.py", line 144, in testDumpMemorySuccess dump_id = self._browser.DumpMemory() File "/mnt/data/b/build/slave/Linux_Tests/build/src/tools/telemetry/telemetry/internal/browser/browser.py", line 291, in DumpMemory return self._browser_backend.DumpMemory(timeout) File "/mnt/data/b/build/slave/Linux_Tests/build/src/tools/telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py", line 321, in DumpMemory return self.devtools_client.DumpMemory(timeout) File "/mnt/data/b/build/slave/Linux_Tests/build/src/tools/telemetry/telemetry/internal/backends/chrome_inspector/devtools_client_backend.py", line 231, in DumpMemory return self._tracing_backend.DumpMemory(timeout) File "/mnt/data/b/build/slave/Linux_Tests/build/src/tools/telemetry/telemetry/internal/backends/chrome_inspector/tracing_backend.py", line 128, in DumpMemory 'Tracing.requestMemoryDump:\n' + json.dumps(response, indent=2)) TracingUnexpectedResponseException: Inspector returned unexpected response for Tracing.requestMemoryDump: { "id": 2, "error": { "message": "Tracing is not started", "code": -32603 } } Original issue's description: > [tracing] Throttle rate of heavy dumps and support to request light/heavy dumps > > Currently all the dump providers dump detailed dumps every periodic > dump. This makes the trace files huge. So, this CL throttles down the > rate of heavy dumps of all the dump providers and removes temporary > hacks. Along with this, this CL also adds support to request light and > heavy dumps by adding MemoryDumpArgs as param to RequestGlobalDump() > > TBR=pfeldman@chromium.org > BUG=499731 > > Committed: https://crrev.com/33f2d3a5b276b70040adfd21edf364bd666b0aa2 > Cr-Commit-Position: refs/heads/master@{#342145} TBR=petrcermak@chromium.org,nduca@chromium.org,pfeldman@chromium.org,ssid@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=499731 Committed: https://crrev.com/563cc9718ff46295e59cb8b3e24df173275d2471 Cr-Commit-Position: refs/heads/master@{#342167}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -107 lines) Patch
M base/trace_event/memory_dump_manager.h View 1 chunk +1 line, -4 lines 0 comments Download
M base/trace_event/memory_dump_manager.cc View 7 chunks +30 lines, -18 lines 0 comments Download
M base/trace_event/memory_dump_manager_unittest.cc View 15 chunks +14 lines, -79 lines 0 comments Download
M base/trace_event/memory_dump_request_args.h View 3 chunks +2 lines, -3 lines 0 comments Download
M base/trace_event/memory_dump_request_args.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/devtools/protocol/tracing_handler.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
waffles
Created Revert of [tracing] Throttle rate of heavy dumps and support to request light/heavy dumps
5 years, 4 months ago (2015-08-06 19:01:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1272703003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1272703003/1
5 years, 4 months ago (2015-08-06 19:03:20 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-06 19:04:59 UTC) #3
commit-bot: I haz the power
5 years, 4 months ago (2015-08-06 19:05:39 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/563cc9718ff46295e59cb8b3e24df173275d2471
Cr-Commit-Position: refs/heads/master@{#342167}

Powered by Google App Engine
This is Rietveld 408576698