src/typing.cc - Issue 1272673003: [es6] Re-implement rest parameters via desugaring.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/typing.cc

Issue 1272673003: [es6] Re-implement rest parameters via desugaring. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Rebase + fix brokenness Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/typing.cc

diff --git a/src/typing.cc b/src/typing.cc

index 1cb7577775622c59880638d2d2bf5067cf5c6d7f..e7d2fae7ebe576b5d5323c550abb7079662d8876 100644

--- a/src/typing.cc

+++ b/src/typing.cc

@@ -371,6 +371,12 @@ void AstTyper::VisitVariableProxy(VariableProxy* expr) {

}

+void AstTyper::VisitRestParameter(RestParameter* node) {

+ // This node should be evicted from the tree before typing ever occurs.

+ UNREACHABLE();

void AstTyper::VisitLiteral(Literal* expr) {

Type* type = Type::Constant(expr->value(), zone());

NarrowType(expr, Bounds(type));