[es6] Re-implement rest parameters via desugaring.

src/parser.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_PARSER_H_
 #define V8_PARSER_H_
 
 #include "src/allocation.h"
 #include "src/ast.h"
 #include "src/compiler.h"  // TODO(titzer): remove this include dependency
@@ skipping 962 matching lines @@
                                 bool* ok);
 
   struct DeclarationDescriptor {
     enum Kind { NORMAL, PARAMETER };
     Parser* parser;
     Scope* declaration_scope;
     Scope* scope;
     Scope* hoist_scope;
     VariableMode mode;
     bool is_const;
+    bool is_rest;
     bool needs_init;
     int declaration_pos;
     int initialization_pos;
     Token::Value init_op;
     Kind declaration_kind;
   };
 
   struct DeclarationParsingResult {
     struct Declaration {
       Declaration(Expression* pattern, int initializer_position,
                   Expression* initializer)
           : pattern(pattern),
             initializer_position(initializer_position),
             initializer(initializer) {}
 
       Expression* pattern;
       int initializer_position;
       Expression* initializer;
+      bool is_rest = false;

[adamk, 2015/08/28 23:26:37]

Does this compile? I think this and the below should be initialized in the
constructor.

[caitp (gmail), 2015/08/28 23:58:01]

Compiles with clang version 3.8.0 (trunk 242792), but will do. This pattern is
used in a few other structs in the tree though

[adamk, 2015/08/29 01:01:07]

Huh, I may just be out of date. Feel free to leave this as-is if we're already
doing this elsewhere.

[caitp (gmail), 2015/08/29 15:51:59]

It turns out these members were unused anyways, so there isn't any reason to
keep them regardless. They're gone

+      int rest_literal_index = 0;
     };
 
     DeclarationParsingResult()
         : declarations(4),
           first_initializer_loc(Scanner::Location::invalid()),
           bindings_loc(Scanner::Location::invalid()) {}
 
     Block* BuildInitializationBlock(ZoneList<const AstRawString*>* names,
                                     bool* ok);
     const AstRawString* SingleName() const;
@@ skipping 320 matching lines @@
       ParserFormalParameters::Parameter(name, pattern, initializer, is_rest),
       parameters->scope->zone());
 }
 
 
 void ParserTraits::DeclareFormalParameter(
     Scope* scope, const ParserFormalParameters::Parameter& parameter,
     ExpressionClassifier* classifier) {
   bool is_duplicate = false;
   bool is_simple = classifier->is_simple_parameter_list();
-  // TODO(caitp): Remove special handling for rest once desugaring is in.
-  auto name = is_simple || parameter.is_rest
-      ? parameter.name : parser_->ast_value_factory()->empty_string();
-  auto mode = is_simple || parameter.is_rest ? VAR : TEMPORARY;
+  auto name = parameter.name;
+  auto mode = is_simple ? VAR : TEMPORARY;
   if (!is_simple) scope->SetHasNonSimpleParameters();
   bool is_optional = parameter.initializer != nullptr;
   Variable* var = scope->DeclareParameter(
       name, mode, is_optional, parameter.is_rest, &is_duplicate);
   if (is_duplicate) {
     classifier->RecordDuplicateFormalParameterError(
         parser_->scanner()->location());
   }
   if (is_sloppy(scope->language_mode())) {
     // TODO(sigurds) Mark every parameter as maybe assigned. This is a
@@ skipping 12 matching lines @@
         parser_->BuildParameterInitializationBlock(parameters, ok);
     if (!*ok) return;
     if (init_block != nullptr) {
       body->Add(init_block, parser_->zone());
     }
   }
 }
 } }  // namespace v8::internal
 
 #endif  // V8_PARSER_H_