clang-format all pdfium code, again.

clang-format all pdfium code, again.

Also add a presubmit that checks for this so I don't have to keep doing it.
No behavior change.

Generated by:
  find . -name '*.cpp' -o -name '*.h' | \
  grep -E -v 'third_party|thirdparties|lpng_v163' | \
  xargs ../../buildtools/mac/clang-format -i

BUG=none
R=thestig@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/4684c83a4e9114a63c64744064dd190e4d459c6f

[Nico, 2015-08-06 20:58:49]

thakis@chromium.org changed reviewers:
+ thestig@chromium.org, tsepez@chromium.org

[Nico, 2015-08-06 20:58:49]

https://codereview.chromium.org/1272653005/diff/1/fpdfsdk/include/javascript/...
File fpdfsdk/include/javascript/app.h (right):

https://codereview.chromium.org/1272653005/diff/1/fpdfsdk/include/javascript/...
fpdfsdk/include/javascript/app.h:232: //	void
This looks like a clang-format misfunction. Why is there a bunch of
commented-out code checked in here? Can we just zap this?

https://codereview.chromium.org/1272653005/diff/1/fpdfsdk/src/fsdk_baseform.cpp
File fpdfsdk/src/fsdk_baseform.cpp (right):

https://codereview.chromium.org/1272653005/diff/1/fpdfsdk/src/fsdk_baseform.c...
fpdfsdk/src/fsdk_baseform.cpp:577: //
ISystemHandle::GetSystemHandler(m_pBaseForm->GetEnv()));
same question

https://codereview.chromium.org/1272653005/diff/1/fpdfsdk/src/fxedit/fxet_ap.cpp
File fpdfsdk/src/fxedit/fxet_ap.cpp (right):

https://codereview.chromium.org/1272653005/diff/1/fpdfsdk/src/fxedit/fxet_ap....
fpdfsdk/src/fxedit/fxet_ap.cpp:202: // line.fLineAscent);
same question

[Lei Zhang, 2015-08-06 21:10:35]

Did you forget to include the DEPS changes for the hook?

[Lei Zhang, 2015-08-06 21:12:04]

https://codereview.chromium.org/1272653005/diff/1/fpdfsdk/include/javascript/...
File fpdfsdk/include/javascript/app.h (right):

https://codereview.chromium.org/1272653005/diff/1/fpdfsdk/include/javascript/...
fpdfsdk/include/javascript/app.h:232: //	void
On 2015/08/06 20:58:49, Nico (hiding) wrote:
> This looks like a clang-format misfunction. Why is there a bunch of
> commented-out code checked in here? Can we just zap this?

Yes.

https://codereview.chromium.org/1272653005/diff/1/public/fpdf_formfill.h
File public/fpdf_formfill.h (right):

https://codereview.chromium.org/1272653005/diff/1/public/fpdf_formfill.h#newc...
public/fpdf_formfill.h:770: /**
Why is this indented?

[Nico, 2015-08-06 21:16:09]

Now with PRESUBMIT.py added and a bunch of uncommented code removed.

https://codereview.chromium.org/1272653005/diff/1/public/fpdf_formfill.h
File public/fpdf_formfill.h (right):

https://codereview.chromium.org/1272653005/diff/1/public/fpdf_formfill.h#newc...
public/fpdf_formfill.h:770: /**
On 2015/08/06 21:12:04, Lei Zhang wrote:
> Why is this indented?

I'm guessing it aligns to the comment in previous line. I added a newline
instead.

[Lei Zhang, 2015-08-06 21:21:25]

https://codereview.chromium.org/1272653005/diff/40001/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/1272653005/diff/40001/PRESUBMIT.py#newcode5
PRESUBMIT.py:5: """Presubmit script for ozone.
not ozone

https://codereview.chromium.org/1272653005/diff/40001/public/fpdf_formfill.h
File public/fpdf_formfill.h (right):

https://codereview.chromium.org/1272653005/diff/40001/public/fpdf_formfill.h#...
public/fpdf_formfill.h:772: * Function: FORM_DoDocumentAAction
Shouldn't this have 1 more space?

/**
 * blah
 */

[Nico, 2015-08-06 21:28:36]

Thanks! Filed https://llvm.org/bugs/show_bug.cgi?id=24385 for that one comment
misformatting problem mentioned earlier.

https://codereview.chromium.org/1272653005/diff/40001/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/1272653005/diff/40001/PRESUBMIT.py#newcode5
PRESUBMIT.py:5: """Presubmit script for ozone.
On 2015/08/06 21:21:25, Lei Zhang wrote:
> not ozone

Done.

https://codereview.chromium.org/1272653005/diff/40001/public/fpdf_formfill.h
File public/fpdf_formfill.h (right):

https://codereview.chromium.org/1272653005/diff/40001/public/fpdf_formfill.h#...
public/fpdf_formfill.h:772: * Function: FORM_DoDocumentAAction
On 2015/08/06 21:21:25, Lei Zhang wrote:
> Shouldn't this have 1 more space?
> 
> /**
>  * blah
>  */

I think clang-format doesn't touch the relative layout of /** */ comments. These
comment blocks didn't have this space before the first big reformat. I can add
some here if you want, but many other comments in this file (and I'm guessing
other files) don't have that space either.

Maybe clang-format should add a space for this, but currently it doesn't.

[Lei Zhang, 2015-08-06 21:30:40]

lgtm

https://codereview.chromium.org/1272653005/diff/40001/public/fpdf_formfill.h
File public/fpdf_formfill.h (right):

https://codereview.chromium.org/1272653005/diff/40001/public/fpdf_formfill.h#...
public/fpdf_formfill.h:772: * Function: FORM_DoDocumentAAction
On 2015/08/06 21:28:36, Nico (hiding) wrote:
> On 2015/08/06 21:21:25, Lei Zhang wrote:
> > Shouldn't this have 1 more space?
> > 
> > /**
> >  * blah
> >  */
> 
> I think clang-format doesn't touch the relative layout of /** */ comments.
These
> comment blocks didn't have this space before the first big reformat. I can add
> some here if you want, but many other comments in this file (and I'm guessing
> other files) don't have that space either.
> 
> Maybe clang-format should add a space for this, but currently it doesn't.

Ok, no worries.

[Nico, 2015-08-06 21:34:42]

Committed patchset #4 (id:60001) manually as
4684c83a4e9114a63c64744064dd190e4d459c6f (presubmit successful).