Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1726)

Unified Diff: components/password_manager/core/browser/password_form_manager.h

Issue 1272613002: Remove credentials with empty username (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Implemented checker Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/password_manager/core/browser/password_form_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/password_manager/core/browser/password_form_manager.h
diff --git a/components/password_manager/core/browser/password_form_manager.h b/components/password_manager/core/browser/password_form_manager.h
index f968af0f59988296a01ae757dce23e160db73052..6e97ecd438bbaa4a28d631ff83946c5c544bbb2f 100644
--- a/components/password_manager/core/browser/password_form_manager.h
+++ b/components/password_manager/core/browser/password_form_manager.h
@@ -362,6 +362,12 @@ class PasswordFormManager : public PasswordStoreConsumer {
// from password store.
void CreatePendingCredentials();
+ // If |pending_credentials_.username_value| is not empty, iterates over all
+ // forms from |best_matches_| and deletes from the password store all which
+ // are not PSL-matched, have an empty username, and a password equal to
+ // |pending_credentials_.password_value|.
+ void DeleteEmptyUsernameCredentials();
+
// If |best_matches| contains only one entry then return this entry. Otherwise
// for empty |password| return nullptr and for non-empty |password| returns
// the unique entry in |best_matches_| with the same password, if it exists,
« no previous file with comments | « no previous file | components/password_manager/core/browser/password_form_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698