Use "svn cat" in tools/submit_try

tools/submit_try

 #!/usr/bin/python
 
 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 
 """
 submit_try: Submit a try request.
 
 This is a thin wrapper around the try request utilities in depot_tools which
 adds some validation and supports both git and svn.
 """
 
 
-from contextlib import closing
-
 import httplib
 import json
 import os
 import subprocess
+import svn
 import sys
-import urllib2
 
 
-def GetGlobalVariables():
-  """ Retrieve a global variable from the global_variables.json file. """
-  global_variables_file = ('http://skia.googlecode.com/svn/buildbot/'
-                           'site_config/global_variables.json')
-  with closing(urllib2.urlopen(global_variables_file)) as f:
-    return json.load(f)
-
-
-GLOBAL_VARIABLES = GetGlobalVariables()
+GLOBAL_VARIABLES = json.loads(svn.Svn.Cat('http://skia.googlecode.com/svn/'
+                                          'buildbot/site_config/'
+                                          'global_variables.json'))
 
 
 def GetGlobalVariable(var_name):
   return GLOBAL_VARIABLES[var_name]['value']
 
 
 # Alias which can be used to run a try on every builder.
 ALL_BUILDERS = 'all'
 
 # Contact information for the build master.
 SKIA_BUILD_MASTER_HOST = str(GetGlobalVariable('master_host'))
 SKIA_BUILD_MASTER_PORT = str(GetGlobalVariable('external_port'))
 
 # All try builders have this suffix.
 TRYBOT_SUFFIX = '_Trybot'
 
 # Location of the codereview.settings file in the Skia repo.
 SKIA_URL = 'skia.googlecode.com'
 CODEREVIEW_SETTINGS = '/svn/codereview.settings'
 
 # String for matching the svn url of the try server inside codereview.settings.
 TRYSERVER_SVN_URL = 'TRYSERVER_SVN_URL: '
 
 # Strings used for matching svn config properties.
-URL_STR = 'URL: '
-REPO_ROOT_STR = 'Repository Root: '
+URL_STR = 'URL'
+REPO_ROOT_STR = 'Repository Root'
 
 
 def FindDepotTools():
   """ Find depot_tools on the local machine and return its location. """
   which_cmd = 'where' if os.name == 'nt' else 'which'
   cmd = [which_cmd, 'gcl']
   proc = subprocess.Popen(cmd, stdout=subprocess.PIPE, stderr=subprocess.STDOUT)
   if proc.wait() != 0:
     raise Exception('Couldn\'t find depot_tools in PATH!')
   gcl = proc.communicate()[0].split('\n')[0].rstrip()
   depot_tools_dir = os.path.dirname(gcl)
   return depot_tools_dir
 
 
 def GetCheckoutRoot(is_svn=True):
   """ Determine where the local checkout is rooted.
 
   is_svn: boolean; whether we're in an SVN checkout. If False, assume we're in
       a git checkout.
   """
   if is_svn:
-    svn_cmd = 'svn.bat' if os.name == 'nt' else 'svn'
-    cmd = [svn_cmd, 'info']
-    proc = subprocess.Popen(cmd, stdout=subprocess.PIPE,
-                            stderr=subprocess.STDOUT)
-    if proc.wait() != 0:
-      raise Exception('Couldn\'t find checkout root!')
-    output = proc.communicate()[0].split('\n')
-    url = None
-    repo_root = None
-    for line in output:
-      if line.startswith(REPO_ROOT_STR):
-        repo_root = line[len(REPO_ROOT_STR):].rstrip()
-      elif line.startswith(URL_STR):
-        url = line[len(URL_STR):].rstrip()
+    repo = svn.Svn(os.curdir)
+    svn_info = repo.GetInfo()
+    url = svn_info.get(URL_STR, None)
+    repo_root = svn_info.get(REPO_ROOT_STR, None)
     if not url or not repo_root:
       raise Exception('Couldn\'t find checkout root!')
     if url == repo_root:
       return 'svn'
     return url[len(repo_root)+1:]
   else:
     cmd = ['git', 'rev-parse', '--show-toplevel']
     proc = subprocess.Popen(cmd, stdout=subprocess.PIPE,
                             stderr=subprocess.STDOUT)
     if proc.wait() != 0:
@@ skipping 167 matching lines @@
 
   # Parse and validate the command-line arguments.
   args = ValidateArgs(sys.argv[1:], trybots=trybots, is_svn=is_svn)
 
   # Submit the try request.
   SubmitTryRequest(args, is_svn=is_svn)
 
 
 if __name__ == '__main__':
   sys.exit(main())