Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 1272573008: Revert of Oilpan: catch some self-referential leaks (main thread.) (Closed)

Created:
5 years, 4 months ago by Justin Novosad
Modified:
5 years, 4 months ago
Reviewers:
oilpan-reviews, haraken, sof
CC:
blink-reviews, oilpan-reviews, kouhei+heap_chromium.org, Mads Ager (chromium), hiroshige
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Oilpan: catch some self-referential leaks (main thread.) (patchset #8 id:140001 of https://codereview.chromium.org/1275863002/ ) Reason for revert: Multiple failures on Win Oilpan Debug bot: http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20Oilpan%20%28dbg%29/builds/2018 Original issue's description: > Oilpan: catch some self-referential leaks (main thread.) > > Track the number of SelfKeepAlive<>s that are currently active on > the main thread, so as to be able to detect if any remains on > shutdown. A clear indication of a leak, if so. > > Also add some debugging support for detecting thread shutdown > leaks due to Persistent<>s not being released; see > PersistentRegion::dumpLivePersistents() and ThreadState::cleanup(). > > R=haraken > BUG=420515 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200174 TBR=oilpan-reviews@chromium.org,haraken@chromium.org,sigbjornf@opera.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=420515 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200195

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -80 lines) Patch
M Source/platform/heap/Handle.h View 2 chunks +1 line, -9 lines 0 comments Download
M Source/platform/heap/PersistentNode.h View 2 chunks +0 lines, -9 lines 0 comments Download
M Source/platform/heap/PersistentNode.cpp View 2 chunks +0 lines, -23 lines 0 comments Download
M Source/platform/heap/ThreadState.h View 2 chunks +0 lines, -8 lines 0 comments Download
M Source/platform/heap/ThreadState.cpp View 5 chunks +1 line, -31 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Justin Novosad
Created Revert of Oilpan: catch some self-referential leaks (main thread.)
5 years, 4 months ago (2015-08-07 21:00:59 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1272573008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1272573008/1
5 years, 4 months ago (2015-08-07 21:01:15 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=200195
5 years, 4 months ago (2015-08-07 21:02:15 UTC) #3
sof
5 years, 4 months ago (2015-08-08 05:26:36 UTC) #4
Message was sent while issue was closed.
might as well for the time being, lgtm.

A step too far perhaps to have this assert check in place for these unruly unit
tests, but if anyone wants to chase them out, feel free to land this CL in
parallel with doing so.

Powered by Google App Engine
This is Rietveld 408576698