Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Unified Diff: services/dart/content_handler_main.cc

Issue 1272573005: Add more tracing for content handlers. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/application/content_handler_factory.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: services/dart/content_handler_main.cc
diff --git a/services/dart/content_handler_main.cc b/services/dart/content_handler_main.cc
index 834f8a052e9366514d5fcc0ebd0300f556ce984b..ef342a92cd33ba0008af9b0fef8f7638b2172b27 100644
--- a/services/dart/content_handler_main.cc
+++ b/services/dart/content_handler_main.cc
@@ -90,6 +90,12 @@ class DartContentHandlerApp : public mojo::ApplicationDelegate {
// Overridden from mojo::ApplicationDelegate:
void Initialize(mojo::ApplicationImpl* app) override {
tracing_.Initialize(app);
+
+ // TODO(qsr): This has no effect for now, as the tracing infrastructure
+ // doesn't allow to trace anything before the tracing app connects to the
+ // application.
+ TRACE_EVENT0("dart_content_handler", "DartContentHandler::Initialize");
+
mojo::icu::Initialize(app);
content_handler_.set_handler_task_runner(
base::MessageLoop::current()->task_runner());
@@ -154,6 +160,10 @@ DartContentHandler::CreateApplication(
mojo::URLResponsePtr response) {
base::trace_event::TraceLog::GetInstance()
->SetCurrentThreadBlocksMessageLoop();
+
+ TRACE_EVENT1("dart_content_handler", "DartContentHandler::CreateApplication",
+ "url", response->url.get());
+
base::FilePath application_dir;
std::string url = response->url.get();
if (IsDartZip(response->url.get())) {
« no previous file with comments | « mojo/application/content_handler_factory.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698