Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java

Issue 1272563005: Fix title of webapps being empty (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add TODO comment Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java
index d8ef0e710590612a4d0bb94b7189cc4c0edb3d10..6f2261b9b6596076dcbf5aa2aa38472cb905ea15 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java
@@ -258,7 +258,11 @@ public class WebappActivity extends FullScreenActivity {
}
private void updateTaskDescription() {
- String title = mWebappInfo.shortName() == null
+ // TODO(lalitm): this is actually a temporary fix for the bigger issue of short
+ // name not being set to the meta tag title of the website if the short name
+ // is not present in the manifest. Some discussion is required for this before
+ // a CL which correctly fixes the issue is submitted.
+ String title = TextUtils.isEmpty(mWebappInfo.shortName())
? getActivityTab().getTitle() : mWebappInfo.shortName();
Bitmap icon = mWebappInfo.icon() == null
? getActivityTab().getFavicon() : mWebappInfo.icon();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698