Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(698)

Issue 1272563003: Add 4 more passing tests to CFI buildbot. (Closed)

Created:
5 years, 4 months ago by krasin
Modified:
5 years, 4 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add 4 more passing tests to CFI buildbot. This CL has a moderate chance of breaking the CFI buildbot: while I don't observe any CFI failures, browser_tests and interactive_ui_tests are extremely flaky on my machine, so I could miss some. Should the buildbot be broken, I will quickly remove the failing tests. BUG=chromium:457523 Committed: https://crrev.com/25c1d85e26cfa384e89252462841fbdf6f6bc4d7 Cr-Commit-Position: refs/heads/master@{#342372}

Patch Set 1 #

Patch Set 2 : content_browsertests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
M testing/buildbot/chromium.fyi.json View 1 3 chunks +24 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
krasin
5 years, 4 months ago (2015-08-06 02:37:41 UTC) #2
krasin
On 2015/08/06 02:37:41, krasin wrote: as a side note, BluetoothLowEnergyApiTest consistently kills my machine; I ...
5 years, 4 months ago (2015-08-06 02:39:46 UTC) #3
krasin
Hi Nico, I have added one more test, content_browsertests, after the last CFI failure there ...
5 years, 4 months ago (2015-08-07 00:47:52 UTC) #4
krasin
After additional testing, interactive_ui_tests are definitely free from CFI failures. Focusing on browser tests now.
5 years, 4 months ago (2015-08-07 03:30:21 UTC) #5
Nico
rs-lgtm Impressive progress!
5 years, 4 months ago (2015-08-07 04:38:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1272563003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1272563003/20001
5 years, 4 months ago (2015-08-07 16:12:06 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/54310)
5 years, 4 months ago (2015-08-07 16:57:16 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1272563003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1272563003/20001
5 years, 4 months ago (2015-08-07 16:58:32 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-07 17:27:52 UTC) #13
commit-bot: I haz the power
5 years, 4 months ago (2015-08-07 17:29:17 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/25c1d85e26cfa384e89252462841fbdf6f6bc4d7
Cr-Commit-Position: refs/heads/master@{#342372}

Powered by Google App Engine
This is Rietveld 408576698