Issue 127253002: Valgrind: Suppress NSS leak in NegotiatingAuthenticatorTest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 127253002: Valgrind: Suppress NSS leak in NegotiatingAuthenticatorTest. (Closed)

Created:
6 years, 11 months ago by Lei Zhang

Modified:
6 years, 11 months ago

Reviewers:
wtc

CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Valgrind: Suppress NSS leak in NegotiatingAuthenticatorTest. BUG=124445 NOTRY=true TBR=wtc@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243451

Patch Set 1 #

Total comments: 1

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -0 lines)			Patch
	M	tools/valgrind/memcheck/suppressions.txt	View		1 chunk	+10 lines, -0 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/127253002/1

6 years, 11 months ago (2014-01-08 00:46:55 UTC) #2

wtc

6 years, 11 months ago (2014-01-08 23:33:25 UTC) #4

Message was sent while issue was closed.

Patch set 1 LGTM. Thanks a lot for your help!

Just to clarify: this is a new leak. This is not an old leak whose call stack
changed.

https://codereview.chromium.org/127253002/diff/1/tools/valgrind/memcheck/supp...
File tools/valgrind/memcheck/suppressions.txt (right):

https://codereview.chromium.org/127253002/diff/1/tools/valgrind/memcheck/supp...
tools/valgrind/memcheck/suppressions.txt:3786: fun:PR_Calloc

This suppression is too broad. The stack should have the
_PR_SET_THREAD_RWLOCK_RANK function. But I'm going to remove this suppression
soon, so don't worry about it.

Expand Messages | Collapse Messages