components/precache/content/precache_manager_unittest.cc - Issue 1272443002: Only set precache.last_time when precache ran.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/precache/content/precache_manager_unittest.cc

Issue 1272443002: Only set precache.last_time when precache ran. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@filter_stats

Patch Set: Don't retry often unless backend pending. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/precache/PrecacheServiceLauncher.java ('K') | « components/precache/content/precache_manager.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/precache/content/precache_manager_unittest.cc

diff --git a/components/precache/content/precache_manager_unittest.cc b/components/precache/content/precache_manager_unittest.cc

index 97765b16047631fe4cfc972f110787cd395fe2fc..b22a9f315f4cc8a4599a814f5236940c602c0a82 100644

--- a/components/precache/content/precache_manager_unittest.cc

+++ b/components/precache/content/precache_manager_unittest.cc

@@ -104,9 +104,7 @@ class TestPrecacheCompletionCallback {

public:

TestPrecacheCompletionCallback() : was_on_done_called_(false) {}

- void OnDone() {

- was_on_done_called_ = true;

- }

+ void OnDone(bool precaching_started) { was_on_done_called_ = true; }

PrecacheManager::PrecacheCompletionCallback GetCallback() {

return base::Bind(&TestPrecacheCompletionCallback::OnDone,