chrome/android/javatests/src/org/chromium/chrome/browser/precache/PrecacheServiceTest.java - Issue 1272443002: Only set precache.last_time when precache ran.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/precache/PrecacheServiceTest.java

Issue 1272443002: Only set precache.last_time when precache ran. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@filter_stats

Patch Set: Don't retry often unless backend pending. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/precache/PrecacheServiceLauncher.java ('K') | « chrome/android/javatests/src/org/chromium/chrome/browser/precache/PrecacheServiceLauncherTest.java ('k') | chrome/browser/android/precache/precache_launcher.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/precache/PrecacheServiceTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/precache/PrecacheServiceTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/precache/PrecacheServiceTest.java

index 56345f2bbcf85220be2827c789341f23a7441177..1e4ab3848a61e2595bca2243a92b3557a9f9d9e5 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/precache/PrecacheServiceTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/precache/PrecacheServiceTest.java

@@ -38,8 +38,8 @@ public class PrecacheServiceTest extends ServiceTestCase<MockPrecacheService> {

public void cancel() {}

@Override

- protected void onPrecacheCompleted() {

- mService.handlePrecacheCompleted();

+ protected void onPrecacheCompleted(boolean precacheStarted) {

+ mService.handlePrecacheCompleted(precacheStarted);

}

@@ -125,7 +125,7 @@ public class PrecacheServiceTest extends ServiceTestCase<MockPrecacheService> {

setupService();

startAndChangeDeviceState(getService(), true, false, true);

assertTrue("Precaching should be in progress", getService().isPrecaching());

- mPrecacheLauncher.onPrecacheCompleted();

+ mPrecacheLauncher.onPrecacheCompleted(true);

assertFalse("Precaching should not be in progress after completion",

getService().isPrecaching());

}