Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1152)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/precache/PrecacheLauncher.java

Issue 1272443002: Only set precache.last_time when precache ran. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@filter_stats
Patch Set: Don't retry often unless backend pending. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/precache/PrecacheLauncher.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/precache/PrecacheLauncher.java b/chrome/android/java/src/org/chromium/chrome/browser/precache/PrecacheLauncher.java
index efad30ae8e4f9382fff931510de73c8577c592a8..26f639b3e49d141bb9ea3cfdab44e316a426c2ed 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/precache/PrecacheLauncher.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/precache/PrecacheLauncher.java
@@ -46,16 +46,24 @@ public abstract class PrecacheLauncher {
nativeCancel(mNativePrecacheLauncher);
}
- /** Called when a precache cycle completes. */
- protected abstract void onPrecacheCompleted();
+ /**
+ * Called when a precache cycle completes.
+ *
+ * @param tryAgainSoon True iff the precache failed to start due to a transient error and should
+ * be attempted again soon.
+ */
+ protected abstract void onPrecacheCompleted(boolean tryAgainSoon);
/**
* Called by native code when the precache cycle completes. This method exists because an
* abstract method cannot be directly called from native.
+ *
+ * @param tryAgainSoon True iff the precache failed to start due to a transient error and should
+ * be attempted again soon.
*/
@CalledByNative
- private void onPrecacheCompletedCallback() {
- onPrecacheCompleted();
+ private void onPrecacheCompletedCallback(boolean tryAgainSoon) {
+ onPrecacheCompleted(tryAgainSoon);
}
/**
@@ -80,8 +88,8 @@ public abstract class PrecacheLauncher {
// privacyPreferencesManager.shouldPrerender() and nativeShouldRun() can only be executed on
// the UI thread.
- PrecacheServiceLauncher.setIsPrecachingEnabled(
- context, privacyPreferencesManager.shouldPrerender() && nativeShouldRun());
+ PrecacheServiceLauncher.setIsPrecachingEnabled(context.getApplicationContext(),
+ privacyPreferencesManager.shouldPrerender() && nativeShouldRun());
Log.v(TAG, "updateEnabledSync complete");
}
@@ -131,7 +139,7 @@ public abstract class PrecacheLauncher {
private static final PrecacheLauncher sInstance = new PrecacheLauncher() {
@Override
- protected void onPrecacheCompleted() {}
+ protected void onPrecacheCompleted(boolean tryAgainSoon) {}
};
// Initialized by updateEnabled to call updateEnabledSync when the sync

Powered by Google App Engine
This is Rietveld 408576698