chrome/android/javatests/src/org/chromium/chrome/browser/precache/PrecacheLauncherTest.java - Issue 1272443002: Only set precache.last_time when precache ran.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/precache/PrecacheLauncherTest.java

Issue 1272443002: Only set precache.last_time when precache ran. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@filter_stats

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/precache/PrecacheService.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/precache/PrecacheServiceLauncher.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/precache/PrecacheServiceLauncherTest.java » ('j') | chrome/android/javatests/src/org/chromium/chrome/browser/precache/PrecacheServiceLauncherTest.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/precache/PrecacheLauncherTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/precache/PrecacheLauncherTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/precache/PrecacheLauncherTest.java

index d23724674985a53e5bb313f0232000758bbf1c0f..5dbb337f2b58776a26b6994e8851fe2060ac4e72 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/precache/PrecacheLauncherTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/precache/PrecacheLauncherTest.java

@@ -24,7 +24,7 @@ public class PrecacheLauncherTest extends NativeLibraryTestBase {

private class PrecacheLauncherUnderTest extends PrecacheLauncher {

@Override

- protected void onPrecacheCompleted() {}

+ protected void onPrecacheCompleted(boolean precachingStarted) {}

@Override

boolean nativeShouldRun() {