Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3827)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/precache/PrecacheLauncher.java

Issue 1272443002: Only set precache.last_time when precache ran. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@filter_stats
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/precache/PrecacheLauncher.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/precache/PrecacheLauncher.java b/chrome/android/java/src/org/chromium/chrome/browser/precache/PrecacheLauncher.java
index 7292c4c95fc95612b84038ab8e6e243fae26a7ca..e4cb45718739e3459e44336ab892977ce32ec1a2 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/precache/PrecacheLauncher.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/precache/PrecacheLauncher.java
@@ -47,15 +47,15 @@ public abstract class PrecacheLauncher {
}
/** Called when a precache cycle completes. */
- protected abstract void onPrecacheCompleted();
+ protected abstract void onPrecacheCompleted(boolean precacheStarted);
bengr 2015/08/05 23:25:35 Describe the parameter in javadoc.
twifkak 2015/08/06 00:09:46 Done.
/**
* Called by native code when the precache cycle completes. This method exists because an
* abstract method cannot be directly called from native.
*/
@CalledByNative
- private void onPrecacheCompletedCallback() {
- onPrecacheCompleted();
+ private void onPrecacheCompletedCallback(boolean precacheStarted) {
bengr 2015/08/05 23:25:35 Why is this precacheStarted and not precacheComple
twifkak 2015/08/06 00:09:46 Done.
+ onPrecacheCompleted(precacheStarted);
}
/**
@@ -80,8 +80,8 @@ public abstract class PrecacheLauncher {
// privacyPreferencesManager.shouldPrerender() and nativeShouldRun() can only be executed on
// the UI thread.
- PrecacheServiceLauncher.setIsPrecachingEnabled(
- context, privacyPreferencesManager.shouldPrerender() && nativeShouldRun());
+ PrecacheServiceLauncher.setIsPrecachingEnabled(context.getApplicationContext(),
bengr 2015/08/05 23:25:35 Please update comment to explain why getApplicatio
twifkak 2015/08/06 00:09:46 Added comment to PrecacheServiceLauncher.
+ privacyPreferencesManager.shouldPrerender() && nativeShouldRun());
Log.v(TAG, "updateEnabledSync complete");
}
@@ -130,7 +130,7 @@ public abstract class PrecacheLauncher {
private static final PrecacheLauncher sInstance = new PrecacheLauncher() {
@Override
- protected void onPrecacheCompleted() {}
+ protected void onPrecacheCompleted(boolean precacheStarted) {}
};
// Initialized by updateEnabled to call updateEnabledSync when the sync

Powered by Google App Engine
This is Rietveld 408576698