tools/perf/profile_creators/profile_generator.py - Issue 1272433002: Revert of Create classes_util API, change discover to return a list instead of a dict.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/profile_creators/profile_generator.py

Issue 1272433002: Revert of Create classes_util API, change discover to return a list instead of a dict. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/profile_creators/profile_generator.py

diff --git a/tools/perf/profile_creators/profile_generator.py b/tools/perf/profile_creators/profile_generator.py

index dc683828d711e0fc4357e0ec0ce8551881012a91..4c52665525fd13448a736f337bfb058358307e53 100644

--- a/tools/perf/profile_creators/profile_generator.py

+++ b/tools/perf/profile_creators/profile_generator.py

@@ -13,11 +13,11 @@

import tempfile

from profile_creators import profile_extender

+from telemetry.core import discover

from telemetry.core import util

from telemetry.internal.browser import browser_finder

from telemetry.internal.browser import browser_options

from telemetry.internal import story_runner

-from telemetry.util import classes_util

def _DiscoverProfileExtenderClasses():

@@ -25,7 +25,7 @@

os.pardir, 'perf', 'profile_creators'))

base_dir = os.path.abspath(os.path.join(profile_extenders_dir, os.pardir))

- profile_extenders_unfiltered = classes_util.DiscoverClassesByClassName(

+ profile_extenders_unfiltered = discover.DiscoverClasses(

profile_extenders_dir, base_dir, profile_extender.ProfileExtender)

# Remove 'extender' suffix from keys.

« no previous file with comments | « tools/perf/page_sets/__init__.py ('k') | tools/telemetry/telemetry/benchmark_runner.py » ('j') | no next file with comments »