tools/perf/benchmarks/benchmark_smoke_unittest.py - Issue 1272433002: Revert of Create classes_util API, change discover to return a list instead of a dict.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/benchmarks/benchmark_smoke_unittest.py

Issue 1272433002: Revert of Create classes_util API, change discover to return a list instead of a dict. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/benchmarks/benchmark_smoke_unittest.py

diff --git a/tools/perf/benchmarks/benchmark_smoke_unittest.py b/tools/perf/benchmarks/benchmark_smoke_unittest.py

index 17bcdfeb6a6a16d1f14adc91d1bafac1d7ea1e1c..255190f2ebc9bad04f1d3ea1e2d1fe3add9be5a8 100644

--- a/tools/perf/benchmarks/benchmark_smoke_unittest.py

+++ b/tools/perf/benchmarks/benchmark_smoke_unittest.py

@@ -102,11 +102,11 @@

benchmarks_dir = os.path.dirname(__file__)

top_level_dir = os.path.dirname(benchmarks_dir)

- # Using the default of |one_class_per_module=True| means that if a module

- # has multiple benchmarks, only the first one is returned.

+ # Using the default of |index_by_class_name=False| means that if a module

+ # has multiple benchmarks, only the last one is returned.

all_benchmarks = discover.DiscoverClasses(

benchmarks_dir, top_level_dir, benchmark_module.Benchmark,

- one_class_per_module=True)

+ index_by_class_name=False).values()

for benchmark in all_benchmarks:

if sys.modules[benchmark.__module__] in _BLACK_LIST_TEST_MODULES:

continue

« no previous file with comments | « tools/chrome_proxy/live_tests/pagesets/__init__.py ('k') | tools/perf/benchmarks/benchmark_unittest.py » ('j') | no next file with comments »