Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(684)

Unified Diff: components/favicon/core/favicon_driver_impl.h

Issue 1272413002: Remove useless FaviconHandler::PageChangedSinceFaviconWasRequested() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/favicon/core/favicon_driver.h ('k') | components/favicon/core/favicon_driver_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/favicon/core/favicon_driver_impl.h
diff --git a/components/favicon/core/favicon_driver_impl.h b/components/favicon/core/favicon_driver_impl.h
index 7c4c442a10915a68a2d0784e085f3eb7fb253430..68f240c5006a214a1b8665f3e43e920349aa7d11 100644
--- a/components/favicon/core/favicon_driver_impl.h
+++ b/components/favicon/core/favicon_driver_impl.h
@@ -53,8 +53,9 @@ class FaviconDriverImpl : public FaviconDriver {
// FaviconDriver implementation.
void FetchFavicon(const GURL& url) override;
bool IsBookmarked(const GURL& url) override;
- void OnFaviconAvailable(const gfx::Image& image,
+ void OnFaviconAvailable(const GURL& page_url,
const GURL& icon_url,
+ const gfx::Image& image,
bool is_active_favicon) override;
bool HasPendingTasksForTest() override;
@@ -73,7 +74,8 @@ class FaviconDriverImpl : public FaviconDriver {
void SetFaviconOutOfDateForPage(const GURL& url, bool force_reload);
// Broadcasts new favicon URL candidates to FaviconHandlers.
- void OnUpdateFaviconURL(const std::vector<FaviconURL>& candidates);
+ void OnUpdateFaviconURL(const GURL& page_url,
+ const std::vector<FaviconURL>& candidates);
protected:
history::HistoryService* history_service() { return history_service_; }
« no previous file with comments | « components/favicon/core/favicon_driver.h ('k') | components/favicon/core/favicon_driver_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698