components/favicon/content/content_favicon_driver.cc - Issue 1272413002: Remove useless FaviconHandler::PageChangedSinceFaviconWasRequested()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/favicon/content/content_favicon_driver.cc

Issue 1272413002: Remove useless FaviconHandler::PageChangedSinceFaviconWasRequested() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/favicon/content/content_favicon_driver.h ('k') | components/favicon/core/favicon_driver.h » ('j') | components/favicon/ios/web_favicon_driver.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/favicon/content/content_favicon_driver.cc

diff --git a/components/favicon/content/content_favicon_driver.cc b/components/favicon/content/content_favicon_driver.cc

index c4aa894affd32a4b92cf54a7ed393a4b8fac2b11..ef24d10b0f8c12135c05df17cadfa4964b90c2ab 100644

--- a/components/favicon/content/content_favicon_driver.cc

+++ b/components/favicon/content/content_favicon_driver.cc

@@ -133,6 +133,10 @@ void ContentFaviconDriver::SetActiveFaviconImage(const gfx::Image& image) {

GetFaviconStatus().image = image;

}

+bool ContentFaviconDriver::ShouldSendFaviconAvailableNotifications() {

+ return true;

content::FaviconStatus& ContentFaviconDriver::GetFaviconStatus() {

DCHECK(web_contents()->GetController().GetLastCommittedEntry());

return web_contents()->GetController().GetLastCommittedEntry()->GetFavicon();