Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Unified Diff: components/favicon/core/favicon_handler_unittest.cc

Issue 1272413002: Remove useless FaviconHandler::PageChangedSinceFaviconWasRequested() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/favicon/core/favicon_handler_unittest.cc
diff --git a/components/favicon/core/favicon_handler_unittest.cc b/components/favicon/core/favicon_handler_unittest.cc
index 614648bd1bd21f307a7c09ae106344b511b66b8b..55877259209f2342447d7f79d5e39c228e4dfada 100644
--- a/components/favicon/core/favicon_handler_unittest.cc
+++ b/components/favicon/core/favicon_handler_unittest.cc
@@ -252,6 +252,8 @@ class TestFaviconDriver : public FaviconDriver {
image_ = image;
}
+ bool ShouldSendFaviconAvailableNotifications() override { return true; }
+
void OnFaviconAvailable(const gfx::Image& image,
const GURL& icon_url,
bool update_active_favicon) override {
@@ -403,7 +405,7 @@ class TestFaviconHandler : public FaviconHandler {
page_url, icon_url, icon_type, bitmap_data, image.Size()));
}
- bool ShouldSaveFavicon(const GURL& url) override { return true; }
+ bool ShouldSaveFavicon() override { return true; }
GURL page_url_;

Powered by Google App Engine
This is Rietveld 408576698