Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Unified Diff: components/favicon/ios/web_favicon_driver.h

Issue 1272413002: Remove useless FaviconHandler::PageChangedSinceFaviconWasRequested() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/favicon/ios/web_favicon_driver.h
diff --git a/components/favicon/ios/web_favicon_driver.h b/components/favicon/ios/web_favicon_driver.h
index c289748284a4a6573bb9142ad2f61570a54046d2..7d60073a23f36dc78eede3acf67b14034bb6821e 100644
--- a/components/favicon/ios/web_favicon_driver.h
+++ b/components/favicon/ios/web_favicon_driver.h
@@ -29,6 +29,7 @@ class WebFaviconDriver : public web::WebStateObserver,
bookmarks::BookmarkModel* bookmark_model);
// FaviconDriver implementation.
+ void FetchFavicon(const GURL& url) override;
void SaveFavicon() override;
gfx::Image GetFavicon() const override;
bool FaviconIsValid() const override;
@@ -40,6 +41,7 @@ class WebFaviconDriver : public web::WebStateObserver,
GURL GetActiveFaviconURL() override;
void SetActiveFaviconURL(const GURL& url) override;
void SetActiveFaviconImage(const gfx::Image& image) override;
+ bool ShouldSendFaviconAvailableNotifications() override;
private:
friend class web::WebStateUserData<WebFaviconDriver>;
@@ -57,6 +59,9 @@ class WebFaviconDriver : public web::WebStateObserver,
// Returns the active navigation entry's favicon.
web::FaviconStatus& GetFaviconStatus();
+ // The URL passed to FetchFavicon().
+ GURL fetch_favicon_url_;
+
DISALLOW_COPY_AND_ASSIGN(WebFaviconDriver);
};

Powered by Google App Engine
This is Rietveld 408576698