components/favicon/content/content_favicon_driver.h - Issue 1272413002: Remove useless FaviconHandler::PageChangedSinceFaviconWasRequested()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/favicon/content/content_favicon_driver.h

Issue 1272413002: Remove useless FaviconHandler::PageChangedSinceFaviconWasRequested() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/favicon/content/content_favicon_driver.h

diff --git a/components/favicon/content/content_favicon_driver.h b/components/favicon/content/content_favicon_driver.h

index 5a328e88f26c61195f8779f9ae1768ebeba929bc..bf4e641fe2f78af47f3abdc138bed12aca97f97b 100644

--- a/components/favicon/content/content_favicon_driver.h

+++ b/components/favicon/content/content_favicon_driver.h

@@ -49,6 +49,7 @@ class ContentFaviconDriver

GURL GetActiveFaviconURL() override;

void SetActiveFaviconURL(const GURL& url) override;

void SetActiveFaviconImage(const gfx::Image& image) override;

+ bool ShouldSendFaviconAvailableNotifications() override;

protected:

ContentFaviconDriver(content::WebContents* web_contents,

« no previous file with comments | « no previous file | components/favicon/content/content_favicon_driver.cc » ('j') | components/favicon/ios/web_favicon_driver.cc » ('J')