Remove useless FaviconHandler::PageChangedSinceFaviconWasRequested()

components/favicon/core/favicon_handler_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/favicon/core/favicon_handler.h"
 
 #include<set>
 #include<vector>
 
 #include "base/memory/scoped_ptr.h"
@@ skipping 229 matching lines @@
   void SetActiveFaviconURL(const GURL& favicon_url) override {
     favicon_url_ = favicon_url;
   }
 
   gfx::Image GetActiveFaviconImage() { return image_; }
 
   void SetActiveFaviconImage(const gfx::Image& image) override {
     image_ = image;
   }
 
+  bool ShouldSendFaviconAvailableNotifications() override { return true; }
+
   void OnFaviconAvailable(const gfx::Image& image,
                           const GURL& icon_url,
                           bool update_active_favicon) override {
     ++num_favicon_available_;
     available_image_ = image;
     available_icon_url_ = icon_url;
     update_active_favicon_ = update_active_favicon;
     if (!update_active_favicon)
       return;
 
@@ skipping 131 matching lines @@
                           const GURL& icon_url,
                           favicon_base::IconType icon_type,
                           const gfx::Image& image) override {
     scoped_refptr<base::RefCountedMemory> bytes = image.As1xPNGBytes();
     std::vector<unsigned char> bitmap_data(bytes->front(),
                                            bytes->front() + bytes->size());
     history_handler_.reset(new HistoryRequestHandler(
         page_url, icon_url, icon_type, bitmap_data, image.Size()));
   }
 
-  bool ShouldSaveFavicon(const GURL& url) override { return true; }
+  bool ShouldSaveFavicon() override { return true; }
 
   GURL page_url_;
 
  private:
 
   // The unique id of a download request. It will be returned to a
   // FaviconHandler.
   int download_id_;
 
   scoped_ptr<DownloadHandler> download_handler_;
@@ skipping 1286 matching lines @@
   EXPECT_FALSE(driver1.update_active_favicon());
   EXPECT_EQ(3u, driver1.num_favicon_available());
 }
 
 INSTANTIATE_TEST_CASE_P(FaviconHandlerTestActiveFaviconValidityTrueOrFalse,
                         FaviconHandlerActiveFaviconValidityParamTest,
                         ::testing::Bool());
 
 }  // namespace
 }  // namespace favicon