Remove useless FaviconHandler::PageChangedSinceFaviconWasRequested()

components/favicon/core/favicon_driver_impl.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/favicon/core/favicon_driver_impl.h"
 
 #include "base/command_line.h"
 #include "base/logging.h"
 #include "base/metrics/field_trial.h"
 #include "base/strings/string_util.h"
@@ skipping 83 matching lines @@
   }
 }
 
 bool FaviconDriverImpl::IsBookmarked(const GURL& url) {
   return bookmark_model_ && bookmark_model_->IsBookmarked(url);
 }
 
 void FaviconDriverImpl::OnFaviconAvailable(const gfx::Image& image,
                                            const GURL& icon_url,
                                            bool is_active_favicon) {
+  if (!ShouldSendFaviconAvailableNotifications())
+    return;
+
   if (is_active_favicon) {
     bool icon_url_changed = GetActiveFaviconURL() != icon_url;
     // No matter what happens, we need to mark the favicon as being set.
     SetActiveFaviconValidity(true);
     SetActiveFaviconURL(icon_url);
 
     if (image.IsEmpty())
       return;
 
     SetActiveFaviconImage(image);
@@ skipping 30 matching lines @@
     const std::vector<FaviconURL>& candidates) {
   DCHECK(!candidates.empty());
   favicon_handler_->OnUpdateFaviconURL(candidates);
   if (touch_icon_handler_.get())
     touch_icon_handler_->OnUpdateFaviconURL(candidates);
   if (large_icon_handler_.get())
     large_icon_handler_->OnUpdateFaviconURL(candidates);
 }
 
 }  // namespace favicon