Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(885)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1272373004: Fix Mandoline apptests on Windows. (Closed)

Created:
5 years, 4 months ago by jam
Modified:
5 years, 4 months ago
Reviewers:
Elliot Glaysher, sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix Mandoline apptests on Windows. BUG=516862, 517175 Committed: https://crrev.com/3ec0456f6641a6ae7b42c294ffc19b5cf88b7203 Cr-Commit-Position: refs/heads/master@{#342056}

Patch Set 1 : ' #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -8 lines) Patch
M sql/mojo/mojo_vfs.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M sql/mojo/vfs_unittest.cc View 1 chunk +1 line, -1 line 1 comment Download
M ui/gl/gl_implementation_win.cc View 1 chunk +8 lines, -7 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
jam
Elliot: sql/mojo Scott: ui/ https://codereview.chromium.org/1272373004/diff/20001/sql/mojo/vfs_unittest.cc File sql/mojo/vfs_unittest.cc (right): https://codereview.chromium.org/1272373004/diff/20001/sql/mojo/vfs_unittest.cc#newcode85 sql/mojo/vfs_unittest.cc:85: EXPECT_EQ("mojo", std::string(vfs()->zName)); with vs this ...
5 years, 4 months ago (2015-08-05 23:08:44 UTC) #4
Elliot Glaysher
lgtm
5 years, 4 months ago (2015-08-05 23:10:52 UTC) #5
sky
LGTM
5 years, 4 months ago (2015-08-05 23:20:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1272373004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1272373004/20001
5 years, 4 months ago (2015-08-06 00:10:18 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/87079)
5 years, 4 months ago (2015-08-06 01:34:00 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1272373004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1272373004/20001
5 years, 4 months ago (2015-08-06 03:25:43 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 4 months ago (2015-08-06 04:03:05 UTC) #15
commit-bot: I haz the power
5 years, 4 months ago (2015-08-06 04:03:36 UTC) #16
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/3ec0456f6641a6ae7b42c294ffc19b5cf88b7203
Cr-Commit-Position: refs/heads/master@{#342056}

Powered by Google App Engine
This is Rietveld 408576698