Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Unified Diff: extensions/browser/extension_event_histogram_value.h

Issue 1272373003: Add extension event histogram values for messaging, webRequest, and webview. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/extension_event_histogram_value.h
diff --git a/extensions/browser/extension_event_histogram_value.h b/extensions/browser/extension_event_histogram_value.h
index 92054c0919a6258e56120ecff0928a630315c446..03bd28c0ab907ebd70024f74d00c5d12999cc745 100644
--- a/extensions/browser/extension_event_histogram_value.h
+++ b/extensions/browser/extension_event_histogram_value.h
@@ -362,8 +362,39 @@ enum HistogramValue {
SCREENLOCK_PRIVATE_ON_AUTH_ATTEMPTED,
TYPES_CHROME_SETTING_ON_CHANGE,
TYPES_PRIVATE_CHROME_DIRECT_SETTING_ON_CHANGE,
- WEB_VIEW_INTERNAL_ON_MESSAGE, // TODO(kalman): where are the rest of the
- // webview events?
+ WEB_VIEW_INTERNAL_ON_MESSAGE,
+ EXTENSION_VIEW_INTERNAL_ON_LOAD_COMMIT,
+ RUNTIME_ON_REQUEST,
+ RUNTIME_ON_REQUEST_EXTERNAL,
+ CHROME_WEB_VIEW_INTERNAL_ON_CONTEXT_MENU_SHOW,
+ WEB_VIEW_INTERNAL_ON_BEFORE_REQUEST,
+ WEB_VIEW_INTERNAL_ON_BEFORE_SEND_HEADERS,
+ WEB_VIEW_INTERNAL_ON_CLOSE,
+ WEB_VIEW_INTERNAL_ON_COMPLETED,
+ WEB_VIEW_INTERNAL_ON_CONSOLE_MESSAGE,
+ WEB_VIEW_INTERNAL_ON_CONTENT_LOAD,
+ WEB_VIEW_INTERNAL_ON_DIALOG,
+ WEB_VIEW_INTERNAL_ON_DROP_LINK,
+ WEB_VIEW_INTERNAL_ON_EXIT,
+ WEB_VIEW_INTERNAL_ON_EXIT_FULLSCREEN,
+ WEB_VIEW_INTERNAL_ON_FIND_REPLY,
+ WEB_VIEW_INTERNAL_ON_FRAME_NAME_CHANGED,
+ WEB_VIEW_INTERNAL_ON_HEADERS_RECEIVED,
+ WEB_VIEW_INTERNAL_ON_LOAD_ABORT,
+ WEB_VIEW_INTERNAL_ON_LOAD_COMMIT,
+ WEB_VIEW_INTERNAL_ON_LOAD_PROGRESS,
+ WEB_VIEW_INTERNAL_ON_LOAD_REDIRECT,
+ WEB_VIEW_INTERNAL_ON_LOAD_START,
+ WEB_VIEW_INTERNAL_ON_LOAD_STOP,
+ WEB_VIEW_INTERNAL_ON_NEW_WINDOW,
+ WEB_VIEW_INTERNAL_ON_PERMISSION_REQUEST,
+ WEB_VIEW_INTERNAL_ON_RESPONSE_STARTED,
+ WEB_VIEW_INTERNAL_ON_RESPONSIVE,
+ WEB_VIEW_INTERNAL_ON_SIZE_CHANGED,
+ WEB_VIEW_INTERNAL_ON_UNRESPONSIVE,
+ WEB_VIEW_INTERNAL_ON_ZOOM_CHANGE,
+ GUEST_VIEW_INTERNAL_ON_RESIZE,
+
// Last entry: Add new entries above, then run:
// python tools/metrics/histograms/update_extension_histograms.py
ENUM_BOUNDARY

Powered by Google App Engine
This is Rietveld 408576698