Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Side by Side Diff: extensions/browser/guest_view/extensions_guest_view_manager_delegate.cc

Issue 1272373003: Add extension event histogram values for messaging, webRequest, and webview. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/browser/guest_view/extensions_guest_view_manager_delegate.h " 5 #include "extensions/browser/guest_view/extensions_guest_view_manager_delegate.h "
6 6
7 #include "components/guest_view/browser/guest_view_base.h" 7 #include "components/guest_view/browser/guest_view_base.h"
8 #include "components/guest_view/browser/guest_view_manager.h" 8 #include "components/guest_view/browser/guest_view_manager.h"
9 #include "components/guest_view/common/guest_view_constants.h"
9 #include "content/public/browser/browser_context.h" 10 #include "content/public/browser/browser_context.h"
10 #include "content/public/browser/render_process_host.h" 11 #include "content/public/browser/render_process_host.h"
11 #include "extensions/browser/event_router.h" 12 #include "extensions/browser/event_router.h"
12 #include "extensions/browser/guest_view/app_view/app_view_guest.h" 13 #include "extensions/browser/guest_view/app_view/app_view_guest.h"
13 #include "extensions/browser/guest_view/extension_options/extension_options_gues t.h" 14 #include "extensions/browser/guest_view/extension_options/extension_options_gues t.h"
14 #include "extensions/browser/guest_view/extension_view/extension_view_guest.h" 15 #include "extensions/browser/guest_view/extension_view/extension_view_guest.h"
16 #include "extensions/browser/guest_view/guest_view_events.h"
15 #include "extensions/browser/guest_view/mime_handler_view/mime_handler_view_gues t.h" 17 #include "extensions/browser/guest_view/mime_handler_view/mime_handler_view_gues t.h"
16 #include "extensions/browser/guest_view/surface_worker/surface_worker_guest.h" 18 #include "extensions/browser/guest_view/surface_worker/surface_worker_guest.h"
17 #include "extensions/browser/guest_view/web_view/web_view_guest.h" 19 #include "extensions/browser/guest_view/web_view/web_view_guest.h"
18 #include "extensions/browser/process_manager.h" 20 #include "extensions/browser/process_manager.h"
19 #include "extensions/browser/process_map.h" 21 #include "extensions/browser/process_map.h"
20 #include "extensions/common/features/feature.h" 22 #include "extensions/common/features/feature.h"
21 #include "extensions/common/features/feature_provider.h" 23 #include "extensions/common/features/feature_provider.h"
22 24
23 using guest_view::GuestViewBase; 25 using guest_view::GuestViewBase;
24 using guest_view::GuestViewManager; 26 using guest_view::GuestViewManager;
(...skipping 11 matching lines...) Expand all
36 void ExtensionsGuestViewManagerDelegate::DispatchEvent( 38 void ExtensionsGuestViewManagerDelegate::DispatchEvent(
37 const std::string& event_name, 39 const std::string& event_name,
38 scoped_ptr<base::DictionaryValue> args, 40 scoped_ptr<base::DictionaryValue> args,
39 GuestViewBase* guest, 41 GuestViewBase* guest,
40 int instance_id) { 42 int instance_id) {
41 EventFilteringInfo info; 43 EventFilteringInfo info;
42 info.SetInstanceID(instance_id); 44 info.SetInstanceID(instance_id);
43 scoped_ptr<base::ListValue> event_args(new base::ListValue()); 45 scoped_ptr<base::ListValue> event_args(new base::ListValue());
44 event_args->Append(args.release()); 46 event_args->Append(args.release());
45 47
46 EventRouter::DispatchEvent( 48 // GetEventHistogramValue maps guest view event names to their histogram
47 guest->owner_web_contents(), 49 // value. It needs to be like this because the guest view component doesn't
48 guest->browser_context(), 50 // know about extensions, so GuestViewEvent can't have an
49 guest->owner_host(), 51 // extensions::events::HistogramValue as an argument.
50 event_name, 52 events::HistogramValue histogram_value =
51 event_args.Pass(), 53 guest_view_events::GetEventHistogramValue(event_name);
52 EventRouter::USER_GESTURE_UNKNOWN, 54 DCHECK_NE(events::UNKNOWN, histogram_value) << "Event " << event_name
53 info); 55 << " must have a histogram value";
56
57 content::WebContents* owner = guest->owner_web_contents();
58 EventRouter::DispatchEventToSender(
59 owner, guest->browser_context(), owner->GetLastCommittedURL(),
60 guest->owner_host(), histogram_value, event_name, event_args.Pass(),
61 EventRouter::USER_GESTURE_UNKNOWN, info);
54 } 62 }
55 63
56 bool ExtensionsGuestViewManagerDelegate::IsGuestAvailableToContext( 64 bool ExtensionsGuestViewManagerDelegate::IsGuestAvailableToContext(
57 GuestViewBase* guest) { 65 GuestViewBase* guest) {
58 const Feature* feature = 66 const Feature* feature =
59 FeatureProvider::GetAPIFeature(guest->GetAPINamespace()); 67 FeatureProvider::GetAPIFeature(guest->GetAPINamespace());
60 CHECK(feature); 68 CHECK(feature);
61 69
62 ProcessMap* process_map = ProcessMap::Get(context_); 70 ProcessMap* process_map = ProcessMap::Get(context_);
63 CHECK(process_map); 71 CHECK(process_map);
(...skipping 22 matching lines...) Expand all
86 GuestViewManager* manager = GuestViewManager::FromBrowserContext(context_); 94 GuestViewManager* manager = GuestViewManager::FromBrowserContext(context_);
87 manager->RegisterGuestViewType<AppViewGuest>(); 95 manager->RegisterGuestViewType<AppViewGuest>();
88 manager->RegisterGuestViewType<ExtensionOptionsGuest>(); 96 manager->RegisterGuestViewType<ExtensionOptionsGuest>();
89 manager->RegisterGuestViewType<ExtensionViewGuest>(); 97 manager->RegisterGuestViewType<ExtensionViewGuest>();
90 manager->RegisterGuestViewType<MimeHandlerViewGuest>(); 98 manager->RegisterGuestViewType<MimeHandlerViewGuest>();
91 manager->RegisterGuestViewType<SurfaceWorkerGuest>(); 99 manager->RegisterGuestViewType<SurfaceWorkerGuest>();
92 manager->RegisterGuestViewType<WebViewGuest>(); 100 manager->RegisterGuestViewType<WebViewGuest>();
93 } 101 }
94 102
95 } // namespace extensions 103 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698