Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Side by Side Diff: apps/app_shim/app_shim_host_manager_mac.mm

Issue 12723011: Giving focus to an app shim brings windows belonging to that app to the foreground. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "apps/app_shim/app_shim_host_manager_mac.h" 5 #include "apps/app_shim/app_shim_host_manager_mac.h"
6 6
7 #include "apps/app_shim/app_shim_host_mac.h" 7 #include "apps/app_shim/app_shim_host_mac.h"
8 #include "base/bind.h" 8 #include "base/bind.h"
9 #include "base/files/file_path.h" 9 #include "base/files/file_path.h"
10 #include "base/logging.h" 10 #include "base/logging.h"
11 #include "base/path_service.h" 11 #include "base/path_service.h"
12 #include "chrome/browser/browser_process.h" 12 #include "chrome/browser/browser_process.h"
13 #include "chrome/common/chrome_paths.h" 13 #include "chrome/common/chrome_paths.h"
14 #include "content/public/browser/browser_thread.h" 14 #include "content/public/browser/browser_thread.h"
15 #include "chrome/common/mac/app_mode_common.h" 15 #import "chrome/common/mac/app_mode_common.h"
koz (OOO until 15th September) 2013/03/18 03:33:12 Is this necessary? Other places #include this file
jeremya 2013/03/18 04:54:05 I guess not. Removed.
16 16
17 using content::BrowserThread; 17 using content::BrowserThread;
18 18
19 namespace { 19 namespace {
20 20
21 void CreateAppShimHost(const IPC::ChannelHandle& handle) { 21 void CreateAppShimHost(const IPC::ChannelHandle& handle) {
22 // AppShimHost takes ownership of itself. 22 // AppShimHost takes ownership of itself.
23 (new AppShimHost)->ServeChannel(handle); 23 (new AppShimHost)->ServeChannel(handle);
24 } 24 }
25 25
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
62 const IPC::ChannelHandle& handle) { 62 const IPC::ChannelHandle& handle) {
63 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO)); 63 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
64 BrowserThread::PostTask( 64 BrowserThread::PostTask(
65 BrowserThread::UI, FROM_HERE, 65 BrowserThread::UI, FROM_HERE,
66 base::Bind(&CreateAppShimHost, handle)); 66 base::Bind(&CreateAppShimHost, handle));
67 } 67 }
68 68
69 void AppShimHostManager::OnListenError() { 69 void AppShimHostManager::OnListenError() {
70 // TODO(jeremya): set a timeout and attempt to reconstruct the channel. 70 // TODO(jeremya): set a timeout and attempt to reconstruct the channel.
71 } 71 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698