Issue 1272283004: Check the size of of the dyld_all_image_infos structure before using it

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1272283004: Check the size of of the dyld_all_image_infos structure before using it (Closed)

Created:
5 years, 4 months ago by Mark Mentovai

Modified:
5 years, 4 months ago

Reviewers:
Robert Sesek

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master

Target Ref:
refs/heads/master

Project:
crashpad

Visibility:
Public.

More Reviews

Description

Check the size of of the dyld_all_image_infos structure before using it After 6083a2706d55, it is possible to determine the expected size of a versioned structure such as dyld_all_image_infos. The expected size is compared against the actual size of the structure as returned by task_info() (TASK_DYLD_INFO). TEST=crashpad_snapshot_test R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/e74922936da1b5f14fe5f520952646a907dc1478

Patch Set 1 #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -1 line)			Patch
	M	snapshot/mac/process_reader.cc	View		1 chunk	+15 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Mark Mentovai

5 years, 4 months ago (2015-08-13 16:55:44 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
e74922936da1b5f14fe5f520952646a907dc1478 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages