Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 127223004: For comparison, add std::vector. (Closed)

Created:
6 years, 11 months ago by mtklein_C
Modified:
6 years, 11 months ago
Reviewers:
bsalomon, mtklein, caryclark
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

For comparison, add std::vector. Where I've tested, it's second-place to SkTDArray, though the closest API equivalent in our code is SkTArray, which it's significantly faster than. This is probably a good approximation to how fast we can possibly make something like SkTArray that constructs and destroys its values. In fact, it might be worth trying making SkTArray a thin shim over std::vector. BUG= Committed: http://code.google.com/p/skia/source/detail?r=12969

Patch Set 1 #

Patch Set 2 : Try again, disabling exceptions in window stdlib #

Patch Set 3 : add _STATIC_CPPLIB #

Patch Set 4 : undeprecate #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -0 lines) Patch
M bench/StackBench.cpp View 6 chunks +41 lines, -0 lines 0 comments Download
M gyp/common_conditions.gypi View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
mtklein_C
6 years, 11 months ago (2014-01-08 16:06:03 UTC) #1
caryclark
lgtm (use trybots?)
6 years, 11 months ago (2014-01-08 16:13:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/127223004/1
6 years, 11 months ago (2014-01-08 18:26:04 UTC) #3
commit-bot: I haz the power
Change committed as 12969
6 years, 11 months ago (2014-01-08 21:16:08 UTC) #4
mtklein
A revert of this CL has been created in https://codereview.chromium.org/129443002/ by mtklein@google.com. The reason for ...
6 years, 11 months ago (2014-01-08 21:31:00 UTC) #5
mtklein
On 2014/01/08 21:31:00, mtklein wrote: > A revert of this CL has been created in ...
6 years, 11 months ago (2014-01-08 21:34:57 UTC) #6
mtklein
6 years, 11 months ago (2014-01-09 14:47:33 UTC) #7
On 2014/01/08 21:34:57, mtklein wrote:
> On 2014/01/08 21:31:00, mtklein wrote:
> > A revert of this CL has been created in
> > https://codereview.chromium.org/129443002/ by mailto:mtklein@google.com.
> > 
> > The reason for reverting is: VS can't comprehend std::vector without
> > exceptions..
> 
> Note to self, try again adding -D_HAS_EXCEPTIONS=0.

Note to future self: -D_HAS_EXCEPTIONS=0 works great in VS2012.  VS2010 then
barfs in jsoncpp and poppler.  __STATIC_CPPLIB and
_DISABLE_DEPRECATE_STATIC_CPPLIB get very close in VS2010, but it now barfs on
std::string in poppler, and VS2012 grows all kinds of linker problems.  Using
STL without exceptions may just have to wait until VS2010 is no longer relevant,
when we can just -D_HAS_EXCEPTIONS=0.

Powered by Google App Engine
This is Rietveld 408576698