Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: third_party/libaddressinput/chromium/cpp/test/retriever_test.cc

Issue 127223003: [rAc - libaddressinput] Chrome download impl (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: sync'd Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/libaddressinput/chromium/cpp/test/retriever_test.cc
diff --git a/third_party/libaddressinput/chromium/cpp/test/retriever_test.cc b/third_party/libaddressinput/chromium/cpp/test/retriever_test.cc
index 15674fe4d91742c029f92649c191d14eff8b431d..9a1f79e269c2f1ea8648560153383576cde13c72 100644
--- a/third_party/libaddressinput/chromium/cpp/test/retriever_test.cc
+++ b/third_party/libaddressinput/chromium/cpp/test/retriever_test.cc
@@ -41,7 +41,7 @@ class RetrieverTest : public testing::Test {
protected:
RetrieverTest()
: retriever_(FakeDownloader::kFakeDataUrl,
- scoped_ptr<const Downloader>(new FakeDownloader),
+ scoped_ptr<Downloader>(new FakeDownloader),
scoped_ptr<Storage>(new FakeStorage)),
success_(false),
key_(),
@@ -106,14 +106,14 @@ class FaultyDownloader : public Downloader {
// Downloader implementation.
virtual void Download(const std::string& url,
- scoped_ptr<Callback> downloaded) const {
+ scoped_ptr<Callback> downloaded) {
(*downloaded)(false, url, "garbage");
}
};
TEST_F(RetrieverTest, FaultyDownloader) {
Retriever bad_retriever(FakeDownloader::kFakeDataUrl,
- scoped_ptr<const Downloader>(new FaultyDownloader),
+ scoped_ptr<Downloader>(new FaultyDownloader),
scoped_ptr<Storage>(new FakeStorage));
bad_retriever.Retrieve(kKey, BuildCallback());
@@ -130,12 +130,12 @@ class HangingDownloader : public Downloader {
// Downloader implementation.
virtual void Download(const std::string& url,
- scoped_ptr<Callback> downloaded) const {}
+ scoped_ptr<Callback> downloaded) {}
};
TEST_F(RetrieverTest, RequestsDontStack) {
Retriever slow_retriever(FakeDownloader::kFakeDataUrl,
- scoped_ptr<const Downloader>(new HangingDownloader),
+ scoped_ptr<Downloader>(new HangingDownloader),
scoped_ptr<Storage>(new FakeStorage));
slow_retriever.Retrieve(kKey, BuildCallback());

Powered by Google App Engine
This is Rietveld 408576698