Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(700)

Issue 1272203002: Fix local reference leak in OpenApkAsset. (Closed)

Created:
5 years, 4 months ago by Torne
Modified:
5 years, 4 months ago
Reviewers:
nyquist, Yaron
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix local reference leak in OpenApkAsset. OpenApkAsset was incorrectly calling ScopedJavaLocalRef::Release on the name of the asset, causing the local reference to leak. This doesn't matter a great deal in most cases since local references are cleaned up when returning to Java, but for running native unittest APKs this gets called once per test and so it's possible for the local reference table to fill up in some cases. Call obj() instead to get a temporary reference to the jobject, so that the reference is still deleted once it goes out of scope. BUG=516725 Committed: https://crrev.com/d90ac6f278eb61b9beea693763ad374ade10102d Cr-Commit-Position: refs/heads/master@{#341906}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M base/android/apk_assets.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Torne
5 years, 4 months ago (2015-08-05 13:24:23 UTC) #2
Yaron
On 2015/08/05 13:24:23, Torne wrote: lgtm
5 years, 4 months ago (2015-08-05 14:10:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1272203002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1272203002/1
5 years, 4 months ago (2015-08-05 14:17:01 UTC) #5
nyquist
lgtm
5 years, 4 months ago (2015-08-05 14:42:02 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-05 15:59:45 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-08-05 16:01:05 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d90ac6f278eb61b9beea693763ad374ade10102d
Cr-Commit-Position: refs/heads/master@{#341906}

Powered by Google App Engine
This is Rietveld 408576698