Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(834)

Unified Diff: Source/core/frame/FrameView.cpp

Issue 1272143003: Remove code duplication in updateLifecycleToCompositingCleanPlusScrolling. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Try to manually recreate the patch Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/frame/FrameView.h ('k') | Source/core/paint/DeprecatedPaintLayerClipper.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/frame/FrameView.cpp
diff --git a/Source/core/frame/FrameView.cpp b/Source/core/frame/FrameView.cpp
index a73aaf0ee40ba1e0b71b8fe430ffb25bf0596cd5..c534bf3624f88a2e6d691b4df25c90ffc534b9d3 100644
--- a/Source/core/frame/FrameView.cpp
+++ b/Source/core/frame/FrameView.cpp
@@ -2431,22 +2431,16 @@ void FrameView::updateWidgetPositionsIfNeeded()
void FrameView::updateAllLifecyclePhases()
{
- frame().localFrameRoot()->view()->updateAllLifecyclePhasesInternal();
+ frame().localFrameRoot()->view()->updateLifecyclePhasesInternal(AllPhases);
}
// TODO(chrishtr): add a scrolling update lifecycle phase, after compositing and before invalidation.
void FrameView::updateLifecycleToCompositingCleanPlusScrolling()
{
- frame().localFrameRoot()->view()->updateStyleAndLayoutIfNeededRecursive();
- LayoutView* view = layoutView();
- if (view)
- view->compositor()->updateIfNeededRecursive();
- scrollContentsIfNeededRecursive();
-
- ASSERT(lifecycle().state() >= DocumentLifecycle::CompositingClean);
+ frame().localFrameRoot()->view()->updateLifecyclePhasesInternal(OnlyUpToCompositingCleanPlusScrolling);
}
-void FrameView::updateAllLifecyclePhasesInternal()
+void FrameView::updateLifecyclePhasesInternal(LifeCycleUpdateOption phases)
{
// This must be called from the root frame, since it recurses down, not up.
// Otherwise the lifecycles of the frames might be out of sync.
@@ -2462,19 +2456,23 @@ void FrameView::updateAllLifecyclePhasesInternal()
view->compositor()->updateIfNeededRecursive();
scrollContentsIfNeededRecursive();
- invalidateTreeIfNeededRecursive();
- if (view->compositor()->inCompositingMode())
- scrollingCoordinator()->updateAfterCompositingChangeIfNeeded();
+ ASSERT(lifecycle().state() >= DocumentLifecycle::CompositingClean);
- updateCompositedSelectionIfNeeded();
- if (RuntimeEnabledFeatures::frameTimingSupportEnabled())
- updateFrameTimingRequestsIfNeeded();
+ if (phases == AllPhases) {
+ invalidateTreeIfNeededRecursive();
- ASSERT(!view->hasPendingSelection());
- }
+ if (view->compositor()->inCompositingMode())
+ scrollingCoordinator()->updateAfterCompositingChangeIfNeeded();
- ASSERT(lifecycle().state() == DocumentLifecycle::PaintInvalidationClean);
+ updateCompositedSelectionIfNeeded();
+ if (RuntimeEnabledFeatures::frameTimingSupportEnabled())
+ updateFrameTimingRequestsIfNeeded();
+
+ ASSERT(!view->hasPendingSelection());
+ ASSERT(lifecycle().state() == DocumentLifecycle::PaintInvalidationClean);
+ }
+ }
}
void FrameView::updateFrameTimingRequestsIfNeeded()
« no previous file with comments | « Source/core/frame/FrameView.h ('k') | Source/core/paint/DeprecatedPaintLayerClipper.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698