Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Side by Side Diff: Source/core/paint/DeprecatedPaintLayerClipper.cpp

Issue 1272143003: Remove code duplication in updateLifecycleToCompositingCleanPlusScrolling. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Try to manually recreate the patch Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/frame/FrameView.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
3 * 3 *
4 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 4 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
5 * 5 *
6 * Other contributors: 6 * Other contributors:
7 * Robert O'Callahan <roc+@cs.cmu.edu> 7 * Robert O'Callahan <roc+@cs.cmu.edu>
8 * David Baron <dbaron@fas.harvard.edu> 8 * David Baron <dbaron@fas.harvard.edu>
9 * Christian Biesinger <cbiesinger@web.de> 9 * Christian Biesinger <cbiesinger@web.de>
10 * Randall Jesup <rjesup@wgate.com> 10 * Randall Jesup <rjesup@wgate.com>
(...skipping 193 matching lines...) Expand 10 before | Expand all | Expand 10 after
204 // This behavior can be seen in the following test 204 // This behavior can be seen in the following test
205 // LayoutTests/compositing/squashing/abspos-under-abspos-overflow-scroll.htm l 205 // LayoutTests/compositing/squashing/abspos-under-abspos-overflow-scroll.htm l
206 if (m_layoutObject.layer() == context.rootLayer) 206 if (m_layoutObject.layer() == context.rootLayer)
207 return LayoutRect(LayoutRect::infiniteIntRect()); 207 return LayoutRect(LayoutRect::infiniteIntRect());
208 208
209 // TODO(chadarmstrong): If possible, all queries should use one of the clipR ectsCacheSlots. 209 // TODO(chadarmstrong): If possible, all queries should use one of the clipR ectsCacheSlots.
210 // Without caching this operation involves walking all the way to rootLayer. 210 // Without caching this operation involves walking all the way to rootLayer.
211 if (!context.usesCache()) 211 if (!context.usesCache())
212 return uncachedBackgroundClipRect(context); 212 return uncachedBackgroundClipRect(context);
213 213
214 // TODO(chadarmstrong): precalculation for painting should be moved to updat eAllLifecyclePhasesInternal 214 // TODO(chadarmstrong): precalculation for painting should be moved to updat eLifecyclePhasesInternal
215 // and precalculation could be done for all hit testing. This would let us a void clearing the cache 215 // and precalculation could be done for all hit testing. This would let us a void clearing the cache
216 if (!m_clips[context.cacheSlot()]) 216 if (!m_clips[context.cacheSlot()])
217 precalculate(context); 217 precalculate(context);
218 218
219 // TODO(chadarmstrong): eliminate this if possible. 219 // TODO(chadarmstrong): eliminate this if possible.
220 // It is necessary only because of a seemingly atypical use of rootLayer tha t 220 // It is necessary only because of a seemingly atypical use of rootLayer tha t
221 // can be seen in LayoutTests/fullscreen/full-screen-line-boxes-crash.html a nd 221 // can be seen in LayoutTests/fullscreen/full-screen-line-boxes-crash.html a nd
222 // fast/block/multicol-paint-invalidation-assert.html. 222 // fast/block/multicol-paint-invalidation-assert.html.
223 if (!m_clips[context.cacheSlot()]) 223 if (!m_clips[context.cacheSlot()])
224 return uncachedBackgroundClipRect(context); 224 return uncachedBackgroundClipRect(context);
(...skipping 221 matching lines...) Expand 10 before | Expand all | Expand 10 after
446 if (context.respectOverflowClip == IgnoreOverflowClip) 446 if (context.respectOverflowClip == IgnoreOverflowClip)
447 return false; 447 return false;
448 448
449 if (layer->isRootLayer() && context.respectOverflowClipForViewport == Ignore OverflowClip) 449 if (layer->isRootLayer() && context.respectOverflowClipForViewport == Ignore OverflowClip)
450 return false; 450 return false;
451 451
452 return true; 452 return true;
453 } 453 }
454 454
455 } // namespace blink 455 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/frame/FrameView.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698