Remove code duplication in updateLifecycleToCompositingCleanPlusScrolling.

Source/core/frame/FrameView.h

 /*
    Copyright (C) 1997 Martin Jones (mjones@kde.org)
              (C) 1998 Waldo Bastian (bastian@kde.org)
              (C) 1998, 1999 Torben Weis (weis@kde.org)
              (C) 1999 Lars Knoll (knoll@kde.org)
              (C) 1999 Antti Koivisto (koivisto@kde.org)
    Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
 
    This library is free software; you can redistribute it and/or
    modify it under the terms of the GNU Library General Public
@@ skipping 592 matching lines @@
 
     // Only for LayoutPart to traverse into sub frames during paint invalidation.
     void invalidateTreeIfNeeded(PaintInvalidationState&);
 
 private:
     explicit FrameView(LocalFrame*);
 
     void setScrollOffset(const IntPoint&, ScrollType) override;
     void setScrollOffset(const DoublePoint&, ScrollType) override;
 
-    void updateAllLifecyclePhasesInternal();
+    enum LifeCycleUpdateOption {
+        AllPhases,
+        OnlyUpToCompositingClean,

[chrishtr, 2015/08/11 16:56:12]

plus scrolling

[ojan, 2015/08/11 17:18:53]

It's weird to me to have a pipeline and list multiple phases in the pipeline.
That said, scrolling isn't an official lifecycle step at the moment. We might
want to make it a lifecycle step. Then this would only be OnlyUptoScrollingClean
as that would imply compositing is clean.

Changed to OnlyUpToCompositingCleanPlusScrolling.

+    };
+
+    void updateLifecyclePhasesInternal(LifeCycleUpdateOption);
     void invalidateTreeIfNeededRecursive();
     void scrollContentsIfNeededRecursive();
     void updateStyleAndLayoutIfNeededRecursive();
     void updatePostLifecycleData();
 
     void reset();
     void init();
 
     void clearLayoutSubtreeRootsAndMarkContainingBlocks();
 
@@ skipping 242 matching lines @@
     static const unsigned visualPixelThreshold = 32 * 32;
     if (m_visuallyNonEmptyPixelCount > visualPixelThreshold)
         setIsVisuallyNonEmpty();
 }
 
 DEFINE_TYPE_CASTS(FrameView, Widget, widget, widget->isFrameView(), widget.isFrameView());
 
 } // namespace blink
 
 #endif // FrameView_h