google_apis/drive/drive_api_url_generator_unittest.cc - Issue 1272113002: Allow url::SchemeHostPort to hold non-file scheme without port

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: google_apis/drive/drive_api_url_generator_unittest.cc

Issue 1272113002: Allow url::SchemeHostPort to hold non-file scheme without port (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: google_apis/drive/drive_api_url_generator_unittest.cc

diff --git a/google_apis/drive/drive_api_url_generator_unittest.cc b/google_apis/drive/drive_api_url_generator_unittest.cc

index 1ccae2fc57e77fdb983d0473c872db6e24462254..9643deae9a965f0b4e80d4c8115783d47ede6e1f 100644

--- a/google_apis/drive/drive_api_url_generator_unittest.cc

+++ b/google_apis/drive/drive_api_url_generator_unittest.cc

@@ -62,7 +62,7 @@ TEST_F(DriveApiUrlGeneratorTest, GetFilesGetUrl) {

url_generator_.GetFilesGetUrl("0ADK06pfg", true, GURL()).spec());

// If |embed_origin| is not empty, it should be added as a query parameter.

- url::AddStandardScheme("chrome-extension");

+ url::AddStandardScheme("chrome-extension", url::SCHEME_WITHOUT_PORT);

EXPECT_EQ(

"https://www.example.com/drive/v2/files/0ADK06pfg"

"?embedOrigin=chrome-extension%3A%2F%2Ftest",

« no previous file with comments | « extensions/test/extensions_unittests_main.cc ('k') | ios/chrome/test/ios_chrome_unit_test_suite.cc » ('j') | no next file with comments »