extensions/shell/common/shell_content_client.cc - Issue 1272113002: Allow url::SchemeHostPort to hold non-file scheme without port

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/shell/common/shell_content_client.cc

Issue 1272113002: Allow url::SchemeHostPort to hold non-file scheme without port (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixing copy assignment 2 Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/shell/common/shell_content_client.cc

diff --git a/extensions/shell/common/shell_content_client.cc b/extensions/shell/common/shell_content_client.cc

index 1879a8f6e447b753b8e9bae981d81699188c9f6a..a4b018299e31c3e05d346d6e59a4b96e6893fba5 100644

--- a/extensions/shell/common/shell_content_client.cc

+++ b/extensions/shell/common/shell_content_client.cc

@@ -77,9 +77,13 @@ void ShellContentClient::AddPepperPlugins(

void ShellContentClient::AddAdditionalSchemes(

std::vector<std::string>* standard_schemes,

std::vector<std::string>* savable_schemes) {

- standard_schemes->push_back(kExtensionScheme);

+ standard_schemes->push_back(

+ url::SchemeWithType(extensions::kExtensionScheme,

+ url::SCHEME_WITHOUT_PORT));

savable_schemes->push_back(kExtensionScheme);

- standard_schemes->push_back(kExtensionResourceScheme);

+ standard_schemes->push_back(

+ url::SchemeWithType(extensions::kExtensionResourceScheme,

+ url::SCHEME_WITHOUT_PORT));

savable_schemes->push_back(kExtensionResourceScheme);

}

« no previous file with comments | « extensions/shell/common/shell_content_client.h ('k') | extensions/test/extensions_unittests_main.cc » ('j') | url/scheme_host_port.cc » ('J')